| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| bridge: add size M for icon-only EventEmittingButton | mediawiki/extensions/Wikibase | master | +38 -9 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Charlie_WMDE | T238728 Step 1: inform about editing on a different project under different license (impact: high) | |||
| Resolved | Lucas_Werkmeister_WMDE | T246227 Add small version of close/cancel button |
Event Timeline
Comment Actions
“Small” here means “size M”, i. e. 32px high just like the ordinary size-M EventEmittingButton. See Bridge Figma and WiKit Figma.
Comment Actions
@Charlie_WMDE as far as I can tell, the close icon itself is currently 14×14 in all sizes in the app. That’s convenient for me as the assignee of this task, because 14×14 is the intended size of the icon and I don’t need to do anything :) – but the WiKit Figma also says that the icon should grow to 16×16 for size L and 20×20 for size XL, which we currently don’t do. The Wikidata Bridge Figma, on the other hand, seems to have the icon at 20×20 for size L already, at least in the Global Bridge Specs section. I’m not sure where that leaves us… does that mean we need more fixes for the app?
Comment Actions
the close icon itself is currently 14×14 in all sizes in the app
(Side note: the computed background-size is 20px, but the image itself contains some padding. I got the 14px by zooming in and using the “measure a portion of the page” tool.)
Comment Actions
Change 577609 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add size M for icon-only EventEmittingButton
Comment Actions
Change 577609 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add size M for icon-only EventEmittingButton
Comment Actions
icon size of license banner looks good but we realised the other icon sizes are not correct. making a new ticket for that and moving this one to done.