[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T245222

Implement opt-in/out of watching talk page in Replying workflow
Closed, ResolvedPublic
Actions

Description

This task is about implementing a way for contributors to opt-in/out of watching the talk page they are replying on within the workflow of replying to a specific comment.

Said differently: after this component is implemented, contributors should be able to put a talk page on their Watchlist [i] and to take a talk page off their Watchlist prior to publishing their reply to a specific comment.

Open questions

  • How should this workflow behave once editing specific comments is implemented (T245225)? Should the "Watch page" affordance be visible

Done

  • Contributors are able to put/take the talk page they are responding on, on/off their Watchlist from within the replying workflow
  • When a contributor is responding on a talk page for the first time, the replying workflow's "Watch page" preference should inherit whatever preference is set in the "Watched pages" section of their Preferences [ii.]

i. https://www.mediawiki.org/wiki/Help:Watchlist
ii. https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-watchlist

Details

SubjectRepoBranchLines +/-
Add "watch this page" checkboxmediawiki/extensions/DiscussionToolsmaster+100 -34
Move checkbox widget creation to mw.libs.vemediawiki/extensions/VisualEditormaster+73 -51
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Feb 14 2020, 12:03 AM
matmarex added a project: DiscussionTools.Feb 21 2020, 5:10 PM
ppelberg updated the task description. (Show Details)Feb 26 2020, 4:32 PM
ppelberg edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team (Tracking).
ppelberg moved this task from Needs Prioritization to Required for Release on the OWC2020 (OWC2020 Replying 2.0) board.
ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.
ppelberg mentioned this in T235593: Replies v2.0: create mockups.Feb 26 2020, 4:35 PM
ppelberg mentioned this in T244498: Replies v2.0: determine what additional instrumentation is needed.Feb 26 2020, 5:11 PM
Esanders added a comment.Feb 29 2020, 5:30 PM

See also T245579: The Reply tool removes pages from my watchlist

Esanders added a comment.Mar 4 2020, 2:26 PM

How should this workflow behave once editing specific comments is implemented (T245225)? Should the "Watch page" affordance be visible

I don't see why not, we always show it when editing a page.

gerritbot added a comment.Mar 4 2020, 4:20 PM

Change 576878 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Add "watch this page" checkbox

https://gerrit.wikimedia.org/r/576878

gerritbot added a project: Patch-For-Review.Mar 4 2020, 4:20 PM
Esanders added a comment.Mar 4 2020, 4:21 PM

Above patch:

image.png (240×632 px, 18 KB)

Esanders moved this task from Upcoming to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 4 2020, 4:21 PM
ppelberg mentioned this in T245221: Replies v2.0: Engineering.Mar 7 2020, 2:14 AM
gerritbot added a comment.Mar 13 2020, 6:00 PM

Change 576855 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Move checkbox widget creation to mw.libs.ve

https://gerrit.wikimedia.org/r/576855

gerritbot added a comment.Mar 13 2020, 6:13 PM

Change 576855 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Move checkbox widget creation to mw.libs.ve

https://gerrit.wikimedia.org/r/576855

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 13 2020, 7:00 PM
ppelberg added a comment.Mar 30 2020, 11:37 PM

Watchlist preferences
Notes from a conversation with @Esanders about how this patch interacts with peoples' existing Watchlist preferences (Preferences > Watchlist):

  • For people who have the Add pages and files I edit to my watchlist preference set to "Yes," the Reply tool will inherit that preference (read: the "Watch this page" checkbox within the Replying workflow will be checked by default).
  • By default, the Add pages and files I edit to my watchlist preference is set to "No" for all wikis, except for Arabic and Czech Wikipedias.
  • The Reply tool will inherit whatever Add pages and files I edit to my watchlist preference a user has set.
  • The Add pages and files I edit to my watchlist preference will not be affected by someone checking the "Watch this page" checkbox within the Replying workflow.
Esanders moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 13 2020, 1:56 PM
Esanders added a project: Editing QA.
Esanders moved this task from Inbox to High Priority on the Editing QA board.
Esanders claimed this task.Apr 13 2020, 2:07 PM
Ryasmeen subscribed.Apr 17 2020, 7:24 PM

@Esanders: So, I checked this on Beta cluster. Everything seem to be working as expected except the watch star does not get updated immediately unless the page is refreshed. Is that something that can be fixed as part of this, or is it a separate existing UI issue with menu bar?

Esanders added a comment.EditedApr 20 2020, 11:38 AM

The main patch hasn't been merged yet, but the watch star should get updated immediately.

gerritbot added a comment.Apr 20 2020, 9:14 PM

Change 576878 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add "watch this page" checkbox

https://gerrit.wikimedia.org/r/576878

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Apr 20 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 20 2020, 10:10 PM
Ryasmeen added a comment.Apr 21 2020, 12:28 AM
In T245222#6071066, @Esanders wrote:

The main patch hasn't been merged yet, but the watch star should get updated immediately.

@Esanders: Right, I see the checkbox now and the watch star is also getting updated correctly. I was checking the part about setting it from Preferences page earlier. But I would like to confirm the following with you.

In T245222#6012991, @ppelberg wrote:

Watchlist preferences
Notes from a conversation with @Esanders about how this patch interacts with peoples' existing Watchlist preferences (Preferences > Watchlist):

  • The Reply tool will inherit whatever Add pages and files I edit to my watchlist preference a user has set.

I see that, this is true only when the checkbox is not overriding it. The checkbox inside the reply tool will always have the higher precedence over the checkbox on the Preferences page, correct?

Esanders added a comment.Apr 21 2020, 10:11 AM

Yes, the checkbox should behave the same as when you are using the full page editor.

Ryasmeen added a comment.EditedApr 21 2020, 7:39 PM
In T245222#6074563, @Esanders wrote:

Yes, the checkbox should behave the same as when you are using the full page editor.

ok got it, so currently the default state of the checkbox inside the Reply tool is always checked regardless of what's set in the Preferences section. I guess that's expected too.

Ryasmeen removed a project: Editing QA.Apr 21 2020, 7:39 PM
Ryasmeen added a comment.EditedApr 21 2020, 7:47 PM
In T245222#6076599, @Ryasmeen wrote:
In T245222#6074563, @Esanders wrote:

Yes, the checkbox should behave the same as when you are using the full page editor.

ok got it, so currently the default state of the checkbox inside the Reply tool is always checked regardless of what's set in the Preferences section. I guess that's expected too.

Never mind! It's not. It does follow the preference, I was already watching it, so it didn't change the state.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 21 2020, 7:48 PM
ppelberg closed this task as Resolved.May 1 2020, 1:20 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 1 2020, 1:20 AM
ppelberg mentioned this in T262988: Conduct pre-deployment design review.Sep 22 2020, 12:06 AM
Esanders added a comment.Mar 25 2021, 1:54 PM

Test wiki created on Patch Demo by Ed using patch(es) linked to this task:

http://localhost/patchdemo/wikis/62c13f4465/w/

Esanders added a comment.Feb 8 2024, 5:55 PM

Test wiki on Patch demo using patch(es) linked to this task was deleted:

http://localhost/patchdemo/wikis/62c13f4465/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits