[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Newcomer tasks: guidance blue dot
Closed, ResolvedPublic

Assigned To
Authored By
MMiller_WMF
Feb 6 2020, 12:53 AM
Referenced Files
F31703838: image.png
Mar 26 2020, 9:05 PM
F31703849: image.png
Mar 26 2020, 9:05 PM
F31703840: image.png
Mar 26 2020, 9:05 PM
F31703845: image.png
Mar 26 2020, 9:05 PM
F31703847: image.png
Mar 26 2020, 9:05 PM
F31703843: image.png
Mar 26 2020, 9:05 PM
F31688037: Screen Shot 2020-03-16 at 7.35.52 PM.png
Mar 17 2020, 11:27 PM
F31688040: Screen Shot 2020-03-16 at 7.35.35 PM.png
Mar 17 2020, 11:27 PM

Description

When the user arrives on a suggested edit article, there should be a pulsing blue dot on the lower right of the edit button on both desktop and mobile. See the images below. When a wiki has two edit tabs (one for VE and one for wikitext), we should put the blue dot on the VE tab. We are preferring VE for newcomers because we think they will have a better experience there, and be more likely to succeed on their first edit.

For each platform and task type, the user should see the dot until they click it -- even if that is not their first visit to a suggested edit article.

The dots can be seen in action in these interactive prototypes:

Mobile

image.png (78×78 px, 1 KB)

Desktop
image.png (44×102 px, 2 KB)

Instrumentation

Below are the portions of our instrumentation plan that relate to this component. See T246919: Newcomer tasks: guidance instrumentation for the full plan.

  • We want to record when the user clicks the “Edit” button. In two-tab wikis on desktop, we need to know whether they chose the VE or wikitext option. One way to figure this out may be with the editattemptstep schema with appropriate oversampling.

Event Timeline

More specifics will be added on where to put the blue dot for wikis that have separate edit tabs for VE and wikitext.

@MMiller_WMF @RHo are there updated requirements for this scenario?

More specifics will be added on where to put the blue dot for wikis that have separate edit tabs for VE and wikitext.

@MMiller_WMF @RHo are there updated requirements for this scenario?

Hi @kostajh @MMiller_WMF - my proposal and preference would be to have the pulse on the VE edit action only in cases where there are different tabs.

When the user arrives on a suggested edit article,

Can you please clarify if the rule should be: "The user arrives on a suggested edit article by clicking on the card in the module" or "The user arrives on a suggested edit article by any means" (e.g. the user organically arrived at the page while reading content on the wiki)

Oops, my answer is in the parent task:

The guidance experience described below should occur after a user arrives on a suggested edit, whether from the homepage or from the post-edit dialog of a previous suggested edit. It should only happen if the user arrives from clicking on a suggestion in one of those locations -- not if they navigate to the article some other way, or are returning to the article after leaving.

Change 574744 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Guidance: Add pulsing blue dot on desktop and mobile

https://gerrit.wikimedia.org/r/574744

Do we plan to display this every time someone clicks a suggested edit card? Seems like it would be mildly annoying after a while.

The patch is a bit different from the prototype:

prototypepatchpatch with long tab
dot-design-mockup.png (49×194 px, 6 KB)
dot-real.png (47×187 px, 6 KB)
dot-real-long.png (48×262 px, 7 KB)

The positioning in the prototype feels more natural, IMO. Also, relative positioning means the dot will be over the text if the text is long enough, so using the same absolute length as the tab might be a better option.

For mobile, the button looks differently on wide screens:

prototypepatchpatch on wide screen
dot-mobile-mockup.png (60×53 px, 3 KB)
dot-mobile-real.png (48×41 px, 3 KB)
dot-mobile-real-wide.png (68×89 px, 3 KB)

Should the dot be on the pencil or the "edit" text in that case?

@RHo can answer about the positioning and visual look of the dot.

@Tgr -- regarding your question about whether the dot will be annoying after a user does several suggested edits, we should include that as part of T246015: Newcomer tasks: opt out of guidance, in which users can opt-out of guidance being pushed to them. I'll add this there.

@RHo can answer about the positioning and visual look of the dot.

  • Hi, apologies if this was not explicit but we should be using the existing pulse that shows on VE and not creating something new - can @Catrope comment on this?

@Tgr -- regarding your question about whether the dot will be annoying after a user does several suggested edits, we should include that as part of T246015: Newcomer tasks: opt out of guidance, in which users can opt-out of guidance being pushed to them. I'll add this there.

  • hi @MMiller_WMF - actually, like the VE pulse, this is a first time only feature that appears the first time a user opens a suggested edit type and not every time. So we do not need to add a config here.

Hi, apologies if this was not explicit but we should be using the existing pulse that shows on VE and not creating something new - can @Catrope comment on this?

The VE pulse adds mw-pulsating-dot class and styles to a button (in VE's case, the Citation button IIRC). We are reusing the same code and styles but the exact placement of the dot is up to us.

actually, like the VE pulse, this is a first time only feature that appears the first time a user opens a suggested edit type and not every time. So we do not need to add a config here.

OK, I'll work that into the patch.

actually, like the VE pulse, this is a first time only feature that appears the first time a user opens a suggested edit type and not every time.

To clarify, the visibility of the dot varies by suggested edit type? Also a question about mobile/desktop:

  1. User is on desktop
  2. User clicks on "Copyedit" task, they see the blue dot
  3. User goes back to homepage and clicks on another "Copyedit" task, no blue dot shown
  4. User goes back to homepage and clicks on "References" task, blue dot is shown or not shown?
  5. User is on mobile, and clicks on a "Copyedit" task -- blue dot is shown or not shown?

Hi, apologies if this was not explicit but we should be using the existing pulse that shows on VE and not creating something new - can @Catrope comment on this?

The VE pulse adds mw-pulsating-dot class and styles to a button (in VE's case, the Citation button IIRC). We are reusing the same code and styles but the exact placement of the dot is up to us.

Thanks that's good to confirm.

Looking at it now, it looks a bit off at the moment because the dot i larger than the prototype, and the 85% position left and top is causing the solid dot to awkwardly hit the bottom and right hand side edges of the tab. I propose we adjust it so that the pulse dot is in the centre and a bit further down in the tab by adjusting the positioning to left: 50%; bottom:0;
This gives the following effect:

image.png (126×328 px, 9 KB)
image.png (98×168 px, 4 KB)
image.png (106×212 px, 5 KB)

And matches the positioning when in shown on VE toolbar items:

image.png (192×384 px, 5 KB)

actually, like the VE pulse, this is a first time only feature that appears the first time a user opens a suggested edit type and not every time.

To clarify, the visibility of the dot varies by suggested edit type? Also a question about mobile/desktop:

  1. User is on desktop
  2. User clicks on "Copyedit" task, they see the blue dot
  3. User goes back to homepage and clicks on another "Copyedit" task, no blue dot shown
  4. User goes back to homepage and clicks on "References" task, blue dot is shown or not shown?
  5. User is on mobile, and clicks on a "Copyedit" task -- blue dot is shown or not shown?

My expectation/hope is that the pulsing blue dot is shown on 4 and 5.

I propose we adjust it so that the pulse dot is in the centre and a bit further down in the tab by adjusting the positioning to left: 50%; bottom:0;

Sounds good for desktop; do you want the existing rules adjusted for mobile as well?

My expectation/hope is that the pulsing blue dot is shown on 4 and 5.

Got it, will update the patch.

I propose we adjust it so that the pulse dot is in the centre and a bit further down in the tab by adjusting the positioning to left: 50%; bottom:0;

Sounds good for desktop; do you want the existing rules adjusted for mobile as well?

Yes please!

My expectation/hope is that the pulsing blue dot is shown on 4 and 5.

Got it, will update the patch.

Sorry I just had a realization I was wrong about showing it once only. The rule should be Show the dot until the edit action is clicked for the particular task type and skin - this is in line with the behaviour of existing pulsing dots on VE citation and link buttons.

@RHo OK, I think my last business rule question is: when there are two tabs (Edit and Edit Source), the blue dot is on "Edit" -- if the user clicks "Edit source" does that count as an edit action for the purposes of showing the blue dot the next time that the user looks at an article with the same task type and skin?

@RHo OK, I think my last business rule question is: when there are two tabs (Edit and Edit Source), the blue dot is on "Edit" -- if the user clicks "Edit source" does that count as an edit action for the purposes of showing the blue dot the next time that the user looks at an article with the same task type and skin?

Hmmm, my conjecture is that a user would click "Edit source" here because they either (a) want to edit in wikitext as their preferred type of editor; or (b) they accidentally clicked on 'Edit source' not realizing the difference.
Based on this, my preference is to still keep the blue dot until Edit is clicked since we want to err on helping the scenario (b) user, since the a user who is savvy enough to click on Edit source is going to ignore the blue dot anyway. Plus, we are likely tailoring guidance content for editing using VE so it makes sense to keep the highlight on this until it is clicked.
Having said that, please comment @MMiller_WMF if you disagree.

Change 574744 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Guidance: Add pulsing blue dot on desktop and mobile

https://gerrit.wikimedia.org/r/574744

@RHo @kostajh -- I have updated the task description to try to succinctly summarize the business rule you've been discussing about when the dot appears and doesn't:

For each platform and task type, the user should see the dot until they click it -- even if that is not their first visit to a suggested edit article.

@MMiller_WMF @nettrom_WMF do we want instrumentation for the presence of the blue dot? (If so I assume it would be part of the helppanel schema.)

@kostajh -- yes, I will be working on instrumentation needs today.

@MMiller_WMF - moved for your review; I've added it to my list of tasks to check after deployment.

Checked in betalabs - the functionality and the UI layout seems to be fine, just one thing to be confirmed - see the red triangle below.

Summary: The blue dot appears when

  • a user is a new user (a user who creates an account, not an old user who enables Homepage or activates SE); new users for whom Homepage is not enabled upon account creation, won't have the blue dot when they enable Homepage via Preferences
  • a new difficulty level is selected (according to the specs)
  • s skin is changed (according to the specs)
  • if a user clicks 'Edit source' first and, without saving any edits, clicks 'Cancel' - the blue dot is still present on 'Edit' tab (seems ok to me).

On mobile arwiki the blue dot is not under the pencil as it's for LTR, it's on the other side of the pencil.

Screen Shot 2020-03-04 at 7.08.06 PM.png (229×1 px, 30 KB)

The screenshots are for illustrations, no problems were found.
(click to see an animated gif)

blue_dot.gif (214×1 px, 12 KB)

(this screenshot is not animated)
Screen Shot 2020-03-04 at 7.44.22 PM.png (360×1 px, 232 KB)

Thanks for assigning this back to Rita. @RHo -- this is now with you.

Thanks @Etonkovidova - I can confirm that the issue you've noticed on arwiki is not expected and the blue dot should still be in the middle of the icon as with the other languages, so popping back into ready for dev.

image.png (1×784 px, 88 KB)

@MMiller_WMF - I also find it unexpected that only completely new users on a language wiki should see the guidance. When I created a new account on arwiki, I saw the blue pulsing dot on an 'easy' task, then when I switched to kowiki and cswiki on the same account and activated, it was unexpected that the blue dot and guidance does not show up on any tasks whatsoever.

@MMiller_WMF - moved for your review; I've added it to my list of tasks to check after deployment.

Checked in betalabs - the functionality and the UI layout seems to be fine, just one thing to be confirmed - see the red triangle below.

Summary: The blue dot appears when

  • a user is a new user (a user who creates an account, not an old user who enables Homepage or activates SE); new users for whom Homepage is not enabled upon account creation, won't have the blue dot when they enable Homepage via Preferences
  • a new difficulty level is selected (according to the specs)
  • s skin is changed (according to the specs)
  • if a user clicks 'Edit source' first and, without saving any edits, clicks 'Cancel' - the blue dot is still present on 'Edit' tab (seems ok to me).

On mobile arwiki the blue dot is not under the pencil as it's for LTR, on the other side of the pencil.

Screen Shot 2020-03-04 at 7.08.06 PM.png (229×1 px, 30 KB)

The screenshots are for illustrations, no problems were found.
(click to see an animated gif)

blue_dot.gif (214×1 px, 12 KB)

(this screenshot is not animated)
Screen Shot 2020-03-04 at 7.44.22 PM.png (360×1 px, 232 KB)

Change 579225 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Adjust the guidance blue dot on Minerva

https://gerrit.wikimedia.org/r/579225

@kostajh @Tgr -- would it be easy to alter the business rules to go along the lines of what @RHo says in her comment? Which would show the blue dot for accounts seeing a new task type for the first time, regardless of whether it's a new account on that wiki?

Which would show the blue dot for accounts seeing a new task type for the first time, regardless of whether it's a new account on that wiki?

That's how it should work. I just tested by creating an account on https://ar.m.wikipedia.beta.wmflabs.org, enabling the homepage and help panel in preferences, then going to https://cs.m.wikipedia.beta.wmflabs.org and enabling the homepage and help panel in preferences. Then I went to https://ar.m.wikipedia.beta.wmflabs.org and switched to the mobile site, and clicked on a suggested edit card and saw the blue dot and mobile peek, then I went to https://cs.m.wikipedia.beta.wmflabs.org and clicked on a suggested edit card and saw the blue dot and mobile peek.

@RHo is it possible you didn't have help panel preference enabled when you visited kowiki/cswiki beta sites?

Which would show the blue dot for accounts seeing a new task type for the first time, regardless of whether it's a new account on that wiki?

That's how it should work. I just tested by creating an account on https://ar.m.wikipedia.beta.wmflabs.org, enabling the homepage and help panel in preferences, then going to https://cs.m.wikipedia.beta.wmflabs.org and enabling the homepage and help panel in preferences. Then I went to https://ar.m.wikipedia.beta.wmflabs.org and switched to the mobile site, and clicked on a suggested edit card and saw the blue dot and mobile peek, then I went to https://cs.m.wikipedia.beta.wmflabs.org and clicked on a suggested edit card and saw the blue dot and mobile peek.

@RHo is it possible you didn't have help panel preference enabled when you visited kowiki/cswiki beta sites?

I had newcomer homepage enabled and expected help pabel to be enabled by default as well. Where should I go to enable Help panel? (I cannot seem to locate it in Preferences in betalabs)

Also, the tweak for showing the blue dot on the centre on RTL @kostajh made looks good to me:

image.png (184×354 px, 3 KB)

I had newcomer homepage enabled and expected help pabel to be enabled by default as well. Where should I go to enable Help panel? (I cannot seem to locate it in Preferences in betalabs)

@RHo you have to go to Special:Preferences#mw-prefsection-editing and then it should be the last checkbox in the second section (Editor).

We could consider making each language wiki (cs/vi/ko/ar) use 100% opt-in settings for the various GrowthExperiments features so there is less setup time to test stuff. But it's a shared environment for lots of projects so not sure if it would be OK for us to do that.

Change 579225 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Adjust the guidance blue dot on Minerva

https://gerrit.wikimedia.org/r/579225

I had newcomer homepage enabled and expected help pabel to be enabled by default as well. Where should I go to enable Help panel? (I cannot seem to locate it in Preferences in betalabs)

@RHo you have to go to Special:Preferences#mw-prefsection-editing and then it should be the last checkbox in the second section (Editor).

  • Ah thank you, the dots are showing up in the new language now after I activate the help panel.

We could consider making each language wiki (cs/vi/ko/ar) use 100% opt-in settings for the various GrowthExperiments features so there is less setup time to test stuff. But it's a shared environment for lots of projects so not sure if it would be OK for us to do that.

  • I think I forgot that help panel opt-in is independent from homepage preference because I expected them both to be in the same place. I think it makes sense to keep the separate prefs but maybe we could consider moving to one location in preferences?

In T244435#5973753, @RHo wrote:

  • I think I forgot that help panel opt-in is independent from homepage preference because I expected them both to be in the same place. I think it makes sense to keep the separate prefs but maybe we could consider moving to one location in preferences?

Enabling Homepage (and Help panel) form User Preferences by users has been viewed as the options that out of the reach for newcomers. But maybe it's time to reconsider that view - there might be quite few use cases when newcomers being proficient in several languages switch between different language wikis and may need Help panel or Homepage to be easier discoverable?

For Design Review:

  • The RTL blue dot position is corrected
    Screen Shot 2020-03-16 at 7.35.52 PM.png (623×377 px, 54 KB)

Screen Shot 2020-03-16 at 7.35.35 PM.png (599×361 px, 46 KB)

LGTM as well, thanks!

CS Mobile
image.png (486×714 px, 50 KB)
CS wider mobile
image.png (242×294 px, 9 KB)
CS Desktop
image.png (146×238 px, 7 KB)
AR Mobile
image.png (214×418 px, 12 KB)
AR wider mobile
image.png (146×222 px, 3 KB)
AR Desktop
image.png (118×186 px, 5 KB)

@kostajh -- I updated the requirements to say that on two-tab wikis, the blue dot should be on the VE on tab. Is that already how you engineered it? Just double-checking.