⚓ T240624 Style desktop Minerva diff page to look like Special:MobileDiff

Subject	Repo	Branch	Lines +/-
Style the desktop diff and history page of Minerva to look like mobile pages	mediawiki/skins/MinervaNeue	master	+340 -6
Diffs: Use JS friendly data timestamp instead of mediawiki timestamp	mediawiki/core	master	+8 -3
DifferenceEngine: Wrap edit, undo thank link tools with CSS parentheses	mediawiki/core	master	+5 -3
Diff: Skins should be able to determine whether they present no comment	mediawiki/core	master	+6 -4

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		Jdlrobson	T240624 Style desktop Minerva diff page to look like Special:MobileDiff

Jdlrobson created this task.Dec 12 2019, 9:22 PM

Jdlrobson edited projects, added MinervaNeue; removed Platform Team Workboards (Clinic Duty Team), Desktop Improvements (Vector 2022), TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions.

I might be wrong here but the diff with mobile with #e07076 and #222 violates AAA WCAG contrast check, also the color of none of the diffs are from the color palette.

In T240624#5738715, @Ladsgroup wrote:

I might be wrong here but the diff with mobile with #e07076 and #222 violates AAA WCAG contrast check, also the color of none of the diffs are from the color palette.

Right now I'm just focused on the technical parts. We can ship different diff colors on a different skin or we can keep them the same.
The issue you talk about is in T90948

Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.Jan 7 2020, 12:45 AM

Jdlrobson moved this task from Backlog to Tech debt on the MinervaNeue board.Jan 17 2020, 11:15 PM

Jdlrobson moved this task from Next up to OKR Backlog on the User-Jdlrobson board.Jul 16 2021, 8:45 PM

Jdlrobson edited projects, added MobileFrontend (MobileFrontend and MinervaNeue architecture), Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).Sep 15 2021, 5:13 PM

Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 16 2021, 4:32 PM

Jdlrobson moved this task from Future Unplanned to Simplify MobileFrontend on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 21 2021, 4:06 PM

Jdlrobson removed a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).Nov 30 2021, 5:53 PM

Jdlrobson moved this task from Simplify MobileFrontend to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 9 2021, 5:42 PM

Jdlrobson moved this task from Future Unplanned to Remove mobile Watchlist special page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 9 2021, 5:56 PM

Jdlrobson triaged this task as Medium priority.Dec 9 2021, 7:45 PM

Samwalton9-WMF added a project: Moderator-Tools-Team.May 11 2022, 1:17 PM

Samwalton9-WMF moved this task from Inbox to Diff/Undo on the Moderator-Tools-Team board.

Samwalton9-WMF mentioned this in T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).

Jdlrobson moved this task from Remove mobile Watchlist special page to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jun 22 2022, 8:39 PM

jsn.sherman mentioned this in T328035: [SPIKE] - Investigate technical approaches for improving mobile diffs [32hrs].Jan 27 2023, 2:26 PM

jsn.sherman mentioned this in T328947: [SPIKE] - Investigate replacing mobile diffs with diffs for moderator tools work [16hrs].Feb 8 2023, 8:32 PM

jsn.sherman mentioned this in T331648: Style desktop Minerva diff page to implement mobile diff design update.Mar 9 2023, 5:18 PM

Jdlrobson claimed this task.Sep 28 2023, 10:50 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Sep 29 2023, 8:55 PM

Jdlrobson updated the task description. (Show Details)Sep 29 2023, 8:58 PM

Change 962095 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Style the desktop diff page of Minerva to look like Special:MobileDiff

https://gerrit.wikimedia.org/r/962095

gerritbot added a project: Patch-For-Review.Sep 29 2023, 11:11 PM

I looked into this today.

Here is a proposed styling of the diff page

Screenshot 2023-09-29 at 4.09.12 PM.png (888×587 px, 141 KB)

The only difference from the existing mobile diff page would be

the use of blue and yellow with legend (instead of red and green) - a longstanding feature request
the page actions would replace the need for the existing edit link, and the "Page" tab would replace the link to the page title

If this is acceptable, this would require the following tickets to be realized:
T347780, T347779

Change 965260 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Diff: Skins should be able to determine whether they present no comment

https://gerrit.wikimedia.org/r/965260

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7c3957d2e6/w

Change 965260 merged by jenkins-bot:

[mediawiki/core@master] Diff: Skins should be able to determine whether they present no comment

https://gerrit.wikimedia.org/r/965260

Change 965789 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] DifferenceEngine: Wrap edit, undo thank link tools with CSS parentheses

https://gerrit.wikimedia.org/r/965789

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 13 2023, 6:00 PM

Change 965789 merged by jenkins-bot:

[mediawiki/core@master] DifferenceEngine: Wrap edit, undo thank link tools with CSS parentheses

https://gerrit.wikimedia.org/r/965789

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.2; 2023-10-24); removed MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 17 2023, 8:00 PM

Change 967265 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Diffs should share unix timestamp instead of mediawiki timestamp

https://gerrit.wikimedia.org/r/967265

Umherirrender mentioned this in T239439: Expose timestamps of diffs (in mw.config or otherwise).Oct 19 2023, 6:56 PM

Please also test with revision deleted content, at the moment the data-timestamp is not provided when the user cannot see the content of the revision. Maybe move that data up to the td with class=diff-otitle/diff-ntitle

Change 958583 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Thanks@master] Thanks should use Codex classes for thanks link on Minerva

https://gerrit.wikimedia.org/r/958583

Change 967265 merged by jenkins-bot:

[mediawiki/core@master] Diffs: Use JS friendly data timestamp instead of mediawiki timestamp

https://gerrit.wikimedia.org/r/967265

Jdlrobson mentioned this in T342556: TypeError: Cannot read properties of undefined (reading 'left') .Oct 24 2023, 8:14 PM

Change 962095 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Style the desktop diff and history page of Minerva to look like mobile pages

https://gerrit.wikimedia.org/r/962095

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.3; 2023-10-31); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 30 2023, 3:01 PM

The mobile diff page and desktop diff page are now styled consistently:

Resolution	Mobile URL	Screenshot of MobileDiff	Desktop URL	Screenshot of Desktop diff
Mobile	URL		URL
Desktop	URL		URL

Thanks @jsn.sherman for the help with this one!

Jdlrobson mentioned this in T350181: Enable desktop diff page on mobile site.Oct 31 2023, 6:31 PM

I realized through T356711 that converging the page styles includes hiding the page content below diffs, overriding the user’s preferences by rewriting the URL. Preferences are there to be honored, why do you ignore them?

I also noticed that title= is included in the URL twice (e.g. https://commons.wikimedia.org/w/index.php?title=Template:ISBN/i18n/en&diff=prev&oldid=407133627&title=Template%3AISBN%2Fi18n%2Fen&diffonly=1), which is clearly a bug (although not one that matters much).

thiemowmde mentioned this in T356725: Revision Slider clutters mobile UI.Feb 7 2024, 3:41 PM

Seems to have caused T357202: Thanks button missing from mobile diff

Jdlrobson merged a task: T331648: Style desktop Minerva diff page to implement mobile diff design update.Mar 19 2024, 12:08 AM

Jdlrobson added a subscriber: • aishwaryavardhana.

Jdlrobson mentioned this in T298988: "Change visibility of selected revisions" button out of alignment on revision history on Minerva.Mar 21 2024, 4:34 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/7c3957d2e6/w/~~

Style desktop Minerva diff page to look like Special:MobileDiff
Closed, ResolvedPublic
Actions

Description

proposal

Details

Related Objects
Search...

Event Timeline

	F41417598: Screenshot 2023-10-31 at 11.15.17 AM.png
	Oct 31 2023, 6:24 PM

	F41417594: Screenshot 2023-10-31 at 11.14.02 AM.png
	Oct 31 2023, 6:24 PM

	F41417604: Screenshot 2023-10-31 at 11.18.55 AM.png
	Oct 31 2023, 6:24 PM

	F41417591: Screenshot 2023-10-31 at 11.13.06 AM.png
	Oct 31 2023, 6:24 PM

	F37855312: Screenshot 2023-09-29 at 4.11.52 PM.png
	Sep 29 2023, 11:13 PM

	F37855310: Screenshot 2023-09-29 at 4.09.12 PM.png
	Sep 29 2023, 11:13 PM

Style desktop Minerva diff page to look like Special:MobileDiff Closed, ResolvedPublicActions