[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T240505

Unbreak now (please) : newly broken CentralNotice admin interface
Closed, ResolvedPublic
Actions

Description

Hey @AndyRussG, some time in the last hour or so, the CentralNotice admin interface changed and certain elements are now broken.

For example:

image.png (166×1 px, 11 KB)

^ Only Save is functional for me.

Index of banners:

image.png (426×1 px, 49 KB)

Details

SubjectRepoBranchLines +/-
Revert "jquery.ui: Remove "jquery.ui.*" and "jquery.effects.*" aliases"mediawiki/corewmf/1.35.0-wmf.10+137 -2
Remove use of jquery.ui module aliasesmediawiki/extensions/CentralNoticewmf/1.35.0-wmf.10+5 -9
Remove use of jquery.ui module aliasesmediawiki/extensions/CentralNoticemaster+5 -9
Remove use of jquery.ui module aliasesmediawiki/extensions/CentralNoticewmf_deploy+5 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

spatton created this task.Dec 11 2019, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2019, 9:03 PM
Pcoombe subscribed.Dec 11 2019, 9:09 PM

I see two related looking javascript errors:

Skipped unresolvable module ext.centralNotice.adminUi.bannerEditor
resolveStubbornly @ load.php?lang=en&modules=startup&

Error: Unknown module: jquery.ui.datepicker

Timing makes me wonder if it's related to the train deployment that just went out?

Pcoombe triaged this task as Unbreak Now! priority.Dec 11 2019, 9:11 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptDec 11 2019, 9:11 PM
• DStrine subscribed.Dec 11 2019, 9:14 PM

We are discussing on IRC. It's possibly due to the train deploy and #wikimedia-operations has been notified.

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Dec 11 2019, 9:19 PM
• DStrine added a project: Fundraising Sprint YAMLton, the Musical.
• Mholloway subscribed.Dec 11 2019, 9:22 PM
Jdforrester-WMF subscribed.Dec 11 2019, 9:23 PM

jquery.ui.datepicker was removed in wmf.10, yes. wmf_deploy strikes yet again.

Agusbou2015 subscribed.Dec 11 2019, 9:31 PM
AndyRussG added a comment.Dec 11 2019, 9:35 PM
In T240505#5733732, @Jdforrester-WMF wrote:

jquery.ui.datepicker was removed in wmf.10, yes. wmf_deploy strikes yet again.

aaaarg... 8p thanks for the quick rollback @Jdforrester-WMF!!!

This is now rolled back on production. There's a whole bunch of jquery.ui stuff... See [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/389d9bff78694c8ded51c98d4eb2b09323f56663/includes/CentralNoticeHooks.php#75 | CentralNoticeHooks.php ]].

AndyRussG added a comment.Dec 11 2019, 9:38 PM

As per T219604, it's just the RL modules aliases that have changed, but the modules are still around, so we should be able to fix pretty easily.

dduvall added a parent task: T233858: 1.35.0-wmf.10 deployment blockers.Dec 11 2019, 9:41 PM
Jdforrester-WMF mentioned this in T240508: CentralNotice is missing from the "deployed" code search results.Dec 11 2019, 9:42 PM
gerritbot added a comment.Dec 11 2019, 9:43 PM

Change 556477 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralNotice@master] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556477

gerritbot added a project: Patch-For-Review.Dec 11 2019, 9:43 PM
gerritbot added a comment.Dec 11 2019, 10:04 PM

Change 556483 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@wmf/1.35.0-wmf.10] Revert "jquery.ui: Remove "jquery.ui.*" and "jquery.effects.*" aliases"

https://gerrit.wikimedia.org/r/556483

gerritbot added a comment.Dec 11 2019, 10:12 PM

Change 556477 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556477

gerritbot added a comment.Dec 11 2019, 10:32 PM

Change 556487 had a related patch set uploaded (by AndyRussG; owner: Jforrester):
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556487

gerritbot added a comment.Dec 11 2019, 10:51 PM

Change 556487 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556487

gerritbot added a comment.Dec 11 2019, 11:03 PM

Change 556497 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.10] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556497

gerritbot added a comment.Dec 11 2019, 11:06 PM

Change 556497 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.10] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556497

Stashbot added a comment.Dec 11 2019, 11:13 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-11T23:13:13Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.10/extensions/CentralNotice/includes/CentralNoticeHooks.php: T240505 Remove CentralNotice's used of deprecated jquery.ui module aliases (duration: 01m 25s)

Jdforrester-WMF closed this task as Resolved.Dec 11 2019, 11:22 PM
Jdforrester-WMF claimed this task.

Declaring this fix.

gerritbot added a comment.Dec 11 2019, 11:24 PM

Change 556483 abandoned by Jforrester:
Revert "jquery.ui: Remove "jquery.ui.*" and "jquery.effects.*" aliases"

https://gerrit.wikimedia.org/r/556483

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2019, 12:10 AM
AndyRussG moved this task from Backlog to Deployed on the Fundraising Sprint YAMLton, the Musical board.Dec 12 2019, 1:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits