We need to add the new campaignStatuses property, which records what happened with campaigns that were fallen back from.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T183978 [Epic] Fundraising kafkatee changes | |||
| Resolved | AndyRussG | T236627 CentralNotice: Adapt impression event schema for campaign fallback |
Event Timeline
Comment Actions
Looks like this became urgent, last week's CentralNotice deployment relies on the new field so we're currently dropping all impressions due to EventLogging validation.
Comment Actions
Change 547561 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547561 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547593 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547593 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547600 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.3] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547602 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.4] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547600 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.3] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Change 547602 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.4] Update CentralNoticeImpression scheme for campaign fallback
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-10-31T18:20:01Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.3/extensions/CentralNotice: SWAT: rECNO963e963b0a7c: Update CentralNoticeImpression scheme for campaign fallback (T236627) (duration: 01m 01s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-10-31T18:21:25Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.4/extensions/CentralNotice: SWAT: rECNO3e5b33f2e094: Update CentralNoticeImpression scheme for campaign fallback (T236627) (duration: 00m 55s)
Comment Actions
Change 547665 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Fix error in CentralNoticeImpression schema
Comment Actions
You probably already noticed, but I found this in the logs, we're double-JSON-encoding the campaignStatuses value:
'[{"statusCode":"2.2","campaign":"WMIL_SeniorcitizenscourseSep2019","bannersCount":1}]' is not of type 'array'
Comment Actions
'[{"statusCode":"2.2","campaign":"WMIL_SeniorcitizenscourseSep2019","bannersCount":1}]' is not of type 'array'
Okay, this was already a known thing according to the code, so I guess the answer is either to make the metawiki schema accept a "string", or have the client send a native data array. Considering how fun CentralNotice deployments can be, I'd lean towards reverting the schema back to "string", and at the same time introducing a new attribute like campaignStatusesData which will accept the array data type. That would be a safer migration, and will make it easier to analyze old campaign data alongside new data.
(Or would we want to migrate old rows in Hadoop?)
Comment Actions
Change 547665 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Fix error in CentralNoticeImpression schema
Comment Actions
Change 547677 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Fix error in CentralNoticeImpression schema
Comment Actions
Change 547679 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.4] Fix error in CentralNoticeImpression schema
Comment Actions
Change 547677 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Fix error in CentralNoticeImpression schema
Comment Actions
Change 547679 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.4] Fix error in CentralNoticeImpression schema
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-10-31T23:26:41Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.4/extensions/CentralNotice/extension.json: SWAT: rECNOdcd3ec30eae3: Fix error in CentralNoticeImpression schema (T236627) (duration: 00m 51s)