[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T235307

Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers)
Closed, ResolvedPublic
Actions

Description

See the discussion starting at T221174#5439782

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Oct 11 2019, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2019, 11:00 PM
Arlolra mentioned this in T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.Oct 11 2019, 11:13 PM
ssastry moved this task from Backlog to Porting Tech Debt Redressal on the Parsoid-PHP board.Oct 16 2019, 1:26 PM
ssastry triaged this task as Medium priority.Oct 24 2019, 8:29 PM
ssastry added a parent task: T239660: Integrate Parsoid/PHP with core as a composer library.Dec 6 2019, 7:05 PM
ssastry subscribed.Jan 2 2020, 5:49 AM

With some git grep, sed, sort, uniq, etc, here is how Env is being used:

Content version functionality:

$env->getInputContentVersion()
$env->getOutputContentVersion()
$env->setInputContentVersion( ... )
$env->setOutputContentVersion( ... )
$env->resolveContentVersion( ... )

Properties (some of which are available without going through env)

$env->pageWithOldid
$env->topFrame
$env->getPageConfig()
$env->getPageMainContent() 
$env->langConverterEnabled()

Document creation and logging. Logging is probably handled using the top level logger. As for document creation, need to investigate what that is being used for.

$env->createDocument( ... )
$env->log( ...)

So, overall, this refactoring might not be too hard.

gerritbot added a comment.Jan 2 2020, 6:27 AM

Change 561441 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove $env use from content version resolution functionality

https://gerrit.wikimedia.org/r/561441

gerritbot added a project: Patch-For-Review.Jan 2 2020, 6:27 AM
gerritbot added a comment.Jan 2 2020, 7:09 AM

Change 561447 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Eliminate use of env in content version resolution code

https://gerrit.wikimedia.org/r/561447

ssastry added a comment.Jan 2 2020, 7:11 AM
In T235307#5770013, @ssastry wrote:

With some git grep, sed, sort, uniq, etc, here is how Env is being used:

Content version functionality:

$env->getInputContentVersion()
$env->getOutputContentVersion()
$env->setInputContentVersion( ... )
$env->setOutputContentVersion( ... )
$env->resolveContentVersion( ... )

The above gerrit patches eliminate all but the first two, and those two are primarily initializations and can be eliminated easily as well.

ssastry added a comment.Jan 2 2020, 12:41 PM
In T235307#5770013, @ssastry wrote:

...
So, overall, this refactoring might not be too hard.

Actually might require moving some functionality from the API endpoints into src/Parsoid.php interface so that the API endpoints are themselves lean and simply dispatch to the right Parsoid library API method.

gerritbot added a comment.Jan 4 2020, 9:43 AM

Change 561447 abandoned by Subramanya Sastry:
Eliminate use of $env in content version resolution code

Reason:
squashed into parent patch

https://gerrit.wikimedia.org/r/561447

Arlolra claimed this task.Jan 6 2020, 4:41 PM
ssastry added a project: Parsing-Active-Work.Jan 22 2020, 7:02 AM
gerritbot added a comment.Jan 23 2020, 10:46 PM

Change 561441 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove Env use from content version resolution functionality

https://gerrit.wikimedia.org/r/561441

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2020, 11:10 PM
Stashbot mentioned this in T244412: PHP Warning: A non-numeric value encountered.Feb 10 2020, 9:43 PM
Stashbot mentioned this in T244413: PHP Warning: Use of undefined constant PAGE_UNAVAILABLE - assumed 'PAGE_UNAVAILABLE' (this will throw an Error in a future version of PHP).
Stashbot mentioned this in T242746: Update ParsoidExtensionAPI to be a coherent and functional extension API to aid extension implementations.
Stashbot mentioned this in T235273: Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retired.

Mentioned in SAL (#wikimedia-operations) [2020-02-10T21:43:15Z] <arlolra> Updated Parsoid to 612106d2 (T244412, T244413, T242746, T235273, T235307, T238845, T204618, T240054)

Stashbot mentioned this in T238845: Call to a member function serialize() on null.Feb 10 2020, 9:43 PM
Stashbot mentioned this in T204618: Permit aria-hidden="true" in Sanitizer.
Stashbot mentioned this in T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid.
cscott removed a parent task: T239660: Integrate Parsoid/PHP with core as a composer library.Mar 20 2020, 4:06 PM
gerritbot added a comment.Mar 25 2020, 6:15 PM

Change 583401 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Move substTopLevelTemplates to the entrypoint

https://gerrit.wikimedia.org/r/583401

gerritbot added a project: Patch-For-Review.Mar 25 2020, 6:15 PM
gerritbot added a comment.Mar 25 2020, 6:21 PM

Change 583401 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move substTopLevelTemplates to the entrypoint

https://gerrit.wikimedia.org/r/583401

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2020, 7:10 PM
gerritbot added a comment.Mar 25 2020, 7:46 PM

Change 583423 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Stop passing $env to createRedirectToOldidResponse

https://gerrit.wikimedia.org/r/583423

gerritbot added a project: Patch-For-Review.Mar 25 2020, 7:46 PM

Change 583424 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Pass PageConfig to createEnv

https://gerrit.wikimedia.org/r/583424

gerritbot added a comment.Mar 25 2020, 7:46 PM

Change 583425 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Move getPageMainContent from Env to PageConfig

https://gerrit.wikimedia.org/r/583425

gerritbot added a comment.Mar 25 2020, 7:46 PM

Change 583426 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Stop passing Env to ParsoidHandler::wt2html

https://gerrit.wikimedia.org/r/583426

gerritbot added a comment.Mar 25 2020, 7:46 PM

Change 583427 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Inline check for null revision content

https://gerrit.wikimedia.org/r/583427

gerritbot added a comment.Mar 25 2020, 9:02 PM

Change 583450 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Remove titleShouldExist

https://gerrit.wikimedia.org/r/583450

gerritbot added a comment.Mar 25 2020, 9:02 PM

Change 583451 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Hoist acceptable check

https://gerrit.wikimedia.org/r/583451

gerritbot added a comment.Mar 25 2020, 11:07 PM

Change 583477 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Stop passing Env to PageHandler::getPageContentResponse

https://gerrit.wikimedia.org/r/583477

gerritbot added a comment.Mar 25 2020, 11:08 PM

Change 583478 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Add SiteConfig::languageConverterEnabledForPage

https://gerrit.wikimedia.org/r/583478

gerritbot added a comment.Mar 25 2020, 11:08 PM

Change 583479 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Stop passing Env to "update" methods on ParsoidHandler

https://gerrit.wikimedia.org/r/583479

ssastry moved this task from Incoming Work (but not yet ready) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.Mar 26 2020, 12:03 AM
gerritbot added a comment.Mar 26 2020, 11:36 PM

Change 583787 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Move downgrades to the entrypoint

https://gerrit.wikimedia.org/r/583787

Arlolra added a comment.Mar 27 2020, 12:04 AM

Noting so I don't forget. The use of Env in DataAccess::logLinterData is also suspect,
https://github.com/wikimedia/parsoid/blob/master/extension/src/Config/DataAccess.php#L331-L355

ssastry added a comment.Mar 27 2020, 12:11 AM
In T235307#6003888, @Arlolra wrote:

Noting so I don't forget. The use of Env in DataAccess::logLinterData is also suspect,
https://github.com/wikimedia/parsoid/blob/master/extension/src/Config/DataAccess.php#L331-L355

Yes, absolutely .. I knew it when that patch landed ... but that one should be relatively easy to fix, it appeared at that time.

gerritbot added a comment.Mar 27 2020, 12:25 AM

Change 583423 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Stop passing $env to createRedirectToOldidResponse

https://gerrit.wikimedia.org/r/583423

gerritbot added a comment.Mar 27 2020, 12:31 AM

Change 583424 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Pass PageConfig to createEnv

https://gerrit.wikimedia.org/r/583424

gerritbot added a comment.Mar 27 2020, 2:08 AM

Change 583425 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move getPageMainContent from Env to PageConfig

https://gerrit.wikimedia.org/r/583425

gerritbot added a comment.Mar 27 2020, 2:08 AM

Change 583426 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Stop passing Env to ParsoidHandler::wt2html

https://gerrit.wikimedia.org/r/583426

gerritbot added a comment.Mar 27 2020, 2:10 AM

Change 583427 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Inline check for null revision content

https://gerrit.wikimedia.org/r/583427

gerritbot added a comment.Mar 27 2020, 1:21 PM

Change 583944 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Stop passing Env to DataAccess::logLinterData()

https://gerrit.wikimedia.org/r/583944

gerritbot added a comment.Mar 28 2020, 12:41 AM

Change 583450 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove titleShouldExist

https://gerrit.wikimedia.org/r/583450

gerritbot added a comment.Mar 28 2020, 1:07 AM

Change 583451 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Hoist acceptable check

https://gerrit.wikimedia.org/r/583451

gerritbot added a comment.Mar 28 2020, 1:07 AM

Change 583477 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Stop passing Env to PageHandler::getPageContentResponse

https://gerrit.wikimedia.org/r/583477

gerritbot added a comment.Mar 28 2020, 1:12 AM

Change 583478 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add SiteConfig::languageConverterEnabledForLanguage

https://gerrit.wikimedia.org/r/583478

gerritbot added a comment.Mar 28 2020, 1:12 AM

Change 583479 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Stop passing Env to "update" methods on ParsoidHandler

https://gerrit.wikimedia.org/r/583479

gerritbot added a comment.Mar 28 2020, 1:13 AM

Change 583787 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move downgrades to the entrypoint

https://gerrit.wikimedia.org/r/583787

Arlolra added a comment.Mar 28 2020, 1:15 AM

Just the patch in T235307#6005051 and then this is done.

gerritbot added a comment.Mar 28 2020, 1:32 AM

Change 583944 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Stop passing Env to DataAccess::logLinterData()

https://gerrit.wikimedia.org/r/583944

Arlolra closed this task as Resolved.Mar 28 2020, 1:33 AM
gerritbot added a comment.Mar 28 2020, 2:06 PM

Change 584120 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a8

https://gerrit.wikimedia.org/r/584120

gerritbot added a comment.Mar 30 2020, 3:06 PM

Change 584120 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a8

https://gerrit.wikimedia.org/r/584120

Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM
gerritbot added a comment.Jun 22 2020, 9:25 PM

Change 607105 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a18

https://gerrit.wikimedia.org/r/607105

gerritbot added a project: Patch-For-Review.Jun 22 2020, 9:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits