Add selenium tests to WikibaseCirrusSearch
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Smalyshev
	May 19 2019, 9:54 AM

Description

Currently WikibaseCirrusSearch has zero browser tests. While it has unit tests for the most functionality, unit tests do not guarantee that the whole roundtrip for search works, and there have been instances where all unit tests pass, but search functionality is broken. It would be nice to have functional test suite for the search ensuring that basic functionality and keywords work as expected.

Since CirrusSearch tests right now run on cindy, it could probably make sense to run this part on cindy too. Or make our standard CI selenium tests to be able to support CirrusSearch tests.

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] tests: Add first selenium test	mediawiki/extensions/WikibaseCirrusSearch	master	+3 K -1
	tests: Remove empty placeholder for selenium tests	mediawiki/extensions/WikibaseCirrusSearch	master	+1 -3 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T223789 Add selenium tests to WikibaseCirrusSearch
		Resolved		zeljkofilipin	T223774 The first Selenium test for WikibaseCirrusSearch

Event Timeline

Smalyshev created this task.May 19 2019, 9:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2019, 9:54 AM

debt moved this task from needs triage to Wikibase Search on the Discovery-Search board.May 30 2019, 4:09 PM

Smalyshev mentioned this in T224125: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch.Jun 4 2019, 10:04 PM

Smalyshev added a subtask: T223774: The first Selenium test for WikibaseCirrusSearch.Jul 5 2019, 10:51 PM

Smalyshev updated the task description. (Show Details)

zeljkofilipin closed subtask T223774: The first Selenium test for WikibaseCirrusSearch as Resolved.Jul 8 2019, 10:40 AM

Change 608983 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikibaseCirrusSearch@master] tests: Remove empty placeholder for selenium tests

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /608983

gerritbot added a project: Patch-For-Review.Jul 2 2020, 1:25 AM

Change 608984 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikibaseCirrusSearch@master] [WIP] tests: Add first selenium test

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /608984

Krinkle triaged this task as Low priority.Jul 2 2020, 1:33 AM

Krinkle mentioned this in T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.

Krinkle removed projects: Patch-For-Review, patch-welcome.

Change 608983 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] tests: Remove empty placeholder for selenium tests

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /608983

Krinkle mentioned this in rEWCSc27b164ed0a4: tests: Remove empty placeholder for selenium tests.Jul 2 2020, 2:12 AM

Change 608984 abandoned by Krinkle:
[mediawiki/extensions/WikibaseCirrusSearch@master] [WIP] tests: Add first selenium test

Reason:

https://gerrit.wikimedia.org/r/608984

CBogen raised the priority of this task from Low to Medium.Aug 27 2020, 8:32 PM

Aklapper added a project: CirrusSearch.Nov 17 2020, 8:37 AM