[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation)
Closed, ResolvedPublic

Description

Extension:Moderation relies on PageContentSave hook to (1) remember the new text, (2) return false from this hook, preventing the edit from being saved.

With MCR feature, PageContentSave hook only gets the main content (see PageUpdater::saveRevision), so it's not possible to remember the additional slots (they will be lost on edit).

New hook (e.g. MultiContentSave) should be provided, and all slots should be available from it.

Related Objects

StatusSubtypeAssignedTask
OpenBUG REPORTNone
OpenNone
StalledNone
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
ResolvedNone
ResolvedNone
OpenFeatureNone
OpenNone
OpenFeatureNone
StalledNone
OpenNone
OpenNone
Opendaniel
OpenNone
Resolvededwardspec

Event Timeline

Change 467308 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@master] MCR: provide PageMultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308

edwardspec renamed this task from MCR: PageContentSave hook should receive all slots (for edit-intercepting extensions like Moderation) to MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation).Dec 6 2018, 1:49 AM
edwardspec updated the task description. (Show Details)

@CCicalese_WMF I#m trying to fit this into our roadmap. It has an almost-done patch, just needs some lova and attention. Edward has been waiting on this for a while, but I don't get around to looking into it this week. Any thoughts on where this should be on hour borads so it doesn't fall through the cracks?

I've put it in Platform Team Workboards (Waiting for Review), which we've been using both for tasks that we are waiting for others to review as well as tasks that others are waiting for us to review.

Change 467308 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@master] MCR: provide MultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308

@daniel @CCicalese_WMF Is there anything I can do to get this merged before 1.35 (LTS) gets released?

Change 467308 merged by jenkins-bot:
[mediawiki/core@master] MCR: provide MultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308