Customize query in gerrit
Details
Details
Event Timeline
Comment Actions
This needs a design review. IIRC OOUI-fying of other extensions has been rejected because the current OOUI design is very different from mediawiki.ui.
Comment Actions
By whom? It's certainly not been "rejected" to the knowledge of anyone in Editing – indeed, OOUI-ification is a big part of our work for the next year or so… Before the re-org, UI-Standardization was a big priority for the UX team for everyone to work on.
Comment Actions
"Rejected" was the wrong way to put it, it was put on hold until OOUI becomes more in sync with mediawiki.ui. Unfortunately I don't remember what that project was... so maybe I am just confabulating. In any case, there is a big difference between the two designs and the visual concepts that are used in other places (such as constructive and destructive colors) are not present in OOUI; so I think a nod from Design wouldn't hurt.
(OTOH if we end up not using OOUI for now, the behavior of the dialog on Esc should be fixed. OOUI handles that sanely but the current dialog does not.)
Comment Actions
Change 201230 had a related patch set uploaded (by Gergő Tisza):
Change dialog for Special:MWOAuth to use OOUI
Comment Actions
I guess I messed this task up a but by mixing concerns about the authorization dialog and the special pages (probably what Mark meant by management interfaces). The latter should not be problematic - for forms, OOUI and mediawiki.ui look almost identical, and OAuth does not use mw.ui (and thus looks really ugly) anyway.
Comment Actions
Change 219432 had a related patch set uploaded (by Gergő Tisza):
Switch management interfaces to OOUI
Comment Actions
There are two pending patches for this task:
- https://gerrit.wikimedia.org/r/#/c/205720/ by @MarkTraceur
- https://gerrit.wikimedia.org/r/#/c/219432/ by @Tgr
Somebody please figure out which one is better and abandon the other :)
Comment Actions
Change 205720 had a related patch set uploaded (by Bartosz Dziewoński):
Use new OOUI display format in most forms
Comment Actions
The management form (which is full of info widgets) does not look great in OOUI.
| vform | oauth |
Comment Actions
Change 309924 had a related patch set uploaded (by Gergő Tisza):
Replace HTMLForm info fields with definition lists on management interface
Comment Actions
Change 309924 merged by jenkins-bot:
Replace HTMLForm info fields with definition lists on management interface
Comment Actions
A few more representative screenshots:
| Page | Before | After |
|---|---|---|
| Special:OAuthConsumerRegistration/propose | ||
| Special:OAuthConsumerRegistration/update/(owner-only consumer) | ||
| Special:OAuthListConsumers | ||
| Special:OAuthManageConsumers/(owner-only consumer) | ||
| Special:OAuthManageConsumers/(regular consumer) | ||
| Special:OAuthManageMyGrants/revoke/1 |
Comment Actions
It's almost like the team that built it had no embedded design resources, was disbanded a week after the production rollout so that other projects could be worked on instead, that subsequently the entire department that they worked in was disbanded, and then no product vertical adopted the project as critical feature. I see @Tgr's team's tag on this project, but I'm guessing that mostly he decided to work on it because he continues to care about OAuth as a product.
It would be awesome to see someone put up an OAuth UX centered project for the Developer-Wishlist. OAuth is pretty critical for supporting the bots and tools developer communities which make up a non-trivial portion of our technical contributors.
Comment Actions
Improving the OAuth interface was one of the Reading Infrastructure goals six or seven quarters ago (but I didn't do a good job of it at the time and never got to this task), no one thought of removing the tag after that I suppose. Right now it's mostly personal, yeah (although most of the work behind the OOUI switch is by @matmarex).
It would be awesome to see someone put up an OAuth UX centered project for the Developer-Wishlist. OAuth is pretty critical for supporting the bots and tools developer communities which make up a non-trivial portion of our technical contributors.
Could easily be two (user interface and owner/admin interface). See T75062: OAuth permission screen needs redesign for better usability and comprehension for the first and T103587: Improve OAuth application approval workflow and T98880: Improve OAuth management interface for the second.