-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch "Local"/"User" buttons on menu selector #3493
Comments
|
I think, the simplest way is move focus to "User" button without any other changes. |
Replying to andrew_b:
Woa, I didn't know about query_set_sel(). I'll upload a "fixed" patch in a minute. |
|
(Feel free to ignore this comment.)
IMHO, this dialog is somewhat problematic. I always hesitate on its question, although I'm certainly not an MC novice. It's not quite clear what "local" and "user" mean. Another issue is the use of buttons. Perhaps radios would be more natural there.
I tried to play with some alternatives, just to see if we can arrive at something better:
(I created this in mc2 in a matter of minutes.)
But I don't think these alternatives are a substantial improvement, so let's put this issue to rest. Perhaps in the future we'll add a "Help" button for dialogs; this may alleviate the problem.
(Since I already mentioned mc2: it comes with a snippet that moves the focus to "User".) |
Branch: 3493_user_menu_focused_button
What about the same change for mcedit menu selector? |
Replying to andrew_b:
Ooh, you're right. I didn't know we had this issue in yet another place.
What's the procedure? Should I post a patch that adds the fix, or should I post a patch that includes everything? I'll do both here, but let me know so I know what to do in the future.
"3493-just-mcedit.patch" is just the addition. |
|
|
|
Merged to master: [6c94956].
|
|
Important
This issue was migrated from Trac:
mooffie
(@mooffie)The menu item "Command > Edit menu file" brings up the following dialog:
+------------- Menu edit --------------+
| Which menu file do you want to edit? |
|--------------------------------------|
| [ Local ] [ User ] |
+--------------------------------------+
The first button is "Local", and therefore has the focus. But since users are more likely to want to edit their central user menu, not the local menu, it's better to make the "User" button the first one.
Note
Original attachments:
mooffie
(@mooffie) onJul 1, 2015 at 7:06 UTC
mooffie
(@mooffie) onJul 1, 2015 at 17:43 UTC
mooffie
(@mooffie) onJul 5, 2015 at 15:54 UTC
mooffie
(@mooffie) onJul 5, 2015 at 15:55 UTC
The text was updated successfully, but these errors were encountered: