8000 Switch "Local"/"User" buttons on menu selector · Issue #3493 · MidnightCommander/mc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch "Local"/"User" buttons on menu selector #3493

Closed
mc-butler opened this issue Jul 1, 2015 · 12 comments
Closed

Switch "Local"/"User" buttons on menu selector #3493

mc-butler opened this issue Jul 1, 2015 · 12 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3493
Reporter mooffie (@mooffie)

The menu item "Command > Edit menu file" brings up the following dialog:

+------------- Menu edit --------------+
| Which menu file do you want to edit? |
|--------------------------------------|
| [ Local ] [ User ] |
+--------------------------------------+

The first button is "Local", and therefore has the focus. But since users are more likely to want to edit their central user menu, not the local menu, it's better to make the "User" button the first one.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 1, 2015 at 7:06 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 1, 2015 at 9:47 UTC

I think, the simplest way is move focus to "User" button without any other changes.

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 1, 2015 at 17:42 UTC (comment 1.2)

Replying to andrew_b:

I think, the simplest way is move focus to "User" button without any other changes.

Woa, I didn't know about query_set_sel(). I'll upload a "fixed" patch in a minute.

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 1, 2015 at 17:43 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 1, 2015 at 18:06 UTC (comment 3)

(Feel free to ignore this comment.)

IMHO, this dialog is somewhat problematic. I always hesitate on its question, although I'm certainly not an MC novice. It's not quite clear what "local" and "user" mean. Another issue is the use of buttons. Perhaps radios would be more natural there.

I tried to play with some alternatives, just to see if we can arrive at something better:

http://i.imgur.com/ZjiUaXb.png

(I created this in mc2 in a matter of minutes.)

But I don't think these alternatives are a substantial improvement, so let's put this issue to rest. Perhaps in the future we'll add a "Help" button for dialogs; this may alleviate the problem.

(Since I already mentioned mc2: it comes with a snippet that moves the focus to "User".)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 5, 2015 at 12:57 UTC (comment 4)

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.15

Branch: 3493_user_menu_focused_button
Initial [24cd2ba]

What about the same change for mcedit menu selector?

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 5, 2015 at 15:54 UTC (comment 4.5)

Replying to andrew_b:

What about the same change for mcedit menu selector?

Ooh, you're right. I didn't know we had this issue in yet another place.

What's the procedure? Should I post a patch that adds the fix, or should I post a patch that includes everything? I'll do both here, but let me know so I know what to do in the future.

"3493-just-mcedit.patch" is just the addition.
"3493-everything.patch" is everything.

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 5, 2015 at 15:54 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 5, 2015 at 15:55 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 17, 2015 at 12:53 UTC (comment 6)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author
8A37

Changed by andrew_b (@aborodin) on Aug 17, 2015 at 12:54 UTC (comment 7)

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master
  • Branch state changed from approved to merged

Merged to master: [6c94956].

git log --pretty=oneline bb5807e..6c94956

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 17, 2015 at 12:57 UTC (comment 8)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Development

No branches or pull requests

2 participants
0