8000 Display additional info while viewing (F3) *.iso files · Issue #2006 · MidnightCommander/mc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display additional info while viewing (F3) *.iso files #2006

Closed
mc-butler opened this issue Feb 5, 2010 · 15 comments
Closed

Display additional info while viewing (F3) *.iso files #2006

mc-butler opened this issue Feb 5, 2010 · 15 comments
Assignees
@slavaz
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.9

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2006
Reporter Unknown
Keywords iso9660

Viewing (F3) for e.g. knoppix.iso delivers this output:

Directory listing of /
d---------   0    0    0            2048 Jan 10 2009 [     29 02]  .
d---------   0    0    0            2048 Jan 10 2009 [     29 02]  ..
d---------   0    0    0            2048 Jun 29 2008 [     30 02]  BOOT
d---------   0    0    0            2048 Jan 27 2009 [     32 02]  KNOPPIX

Directory listing of /BOOT/
d---------   0    0    0            2048 Jun 29 2008 [     30 02]  .
d---------   0    0    0            2048 Jan 10 2009 [     29 02]  ..
d---------   0    0    0            2048 Jan 27 2009 [     31 02]  ISOLINUX

...

After applying this patch:

--- mc.ext.org	2010-02-05 02:38:40.000000000 +0100
+++ mc.ext	2010-02-05 19:08:55.000000000 +0100
@@ -241,7 +241,7 @@
 # ISO9660
 regex/\.iso$
 	Open=%cd %p#iso9660
-	View=%view{ascii} isoinfo -l -i %f
+	View=%view{ascii} isoinfo -d -i %f && isoinfo -l -i %f
 
 # 7zip archives (they are not man pages)
 regex/\.(7z|7Z)$

And restarting mc.

Viewing (F3) for e.g. knoppix.iso delivers this output:

CD-ROM is in ISO 9660 format
System id: LINUX
Volume id: KNOPPIX
Volume set id:
Publisher id:
Data preparer id:
Application id: KNOPPIX
Copyright File id:
Abstract File id:
Bibliographic File id:
Volume set size is: 1
Volume set sequence number is: 1
Logical block size is: 2048
Volume size is: 332259
El Torito VD version 1 found, boot catalog is in sector 40
Joliet with UCS level 3 found
Rock Ridge signatures version 1 found
Eltorito validation header:
    Hid 1
    Arch 0 (x86)
    ID ''
    Key 55 AA
    Eltorito defaultboot header:
        Bootid 88 (bootable)
        Boot media 0 (No Emulation Boot)
        Load segment 0
        Sys type 0
        Nsect 4
        Bootoff 29 41

Directory listing of /
d---------   0    0    0            2048 Jan 10 2009 [     29 02]  .
d---------   0    0    0            2048 Jan 10 2009 [     29 02]  ..
d---------   0    0    0            2048 Jun 29 2008 [     30 02]  BOOT
d---------   0    0    0            2048 Jan 27 2009 [     32 02]  KNOPPIX

Directory listing of /BOOT/
d---------   0    0    0            2048 Jun 29 2008 [     30 02]  .
d---------   0    0    0            2048 Jan 10 2009 [     29 02]  ..
d---------   0    0    0            2048 Jan 27 2009 [     31 02]  ISOLINUX

...
@mc-butler
Copy link
Author

Changed by x905 on Feb 12, 2010 at 12:59 UTC (comment 1)

isoinfo has a "bug" - it not show dot-started files and dirs

@mc-butler
Copy link
Author

Changed by Unknown on Feb 12, 2010 at 15:08 UTC (comment 2)

According to: http://en.wikipedia.org/wiki/ISO_9660#File_and_directory_name_restrictions
ISO 9660 File names shall not start or end with the dot character.

@mc-butler
Copy link
Author

Changed by x905 on Feb 15, 2010 at 5:39 UTC (comment 3)

hmm, my fault - isoinfo does show dot started files (for example .discinfo)
mc also show this file then F3 pressed on iso file, but not show then Enter pressed on iso file

@mc-butler
Copy link
Author

Changed by Unknown on Feb 15, 2010 at 16:46 UTC (comment 4)

Does applying this patch help?

--- iso9660.org	2010-02-05 02:38:37.000000000 +0100
+++ iso9660	2010-02-15 17:10:15.000000000 +0100
@@ -62,7 +62,7 @@
   sub(" $", "", name)
   ## sub(";[0-9]+$", "", name) ## would break copyout
   # skip . and ..
-  if (name ~ /^\.\.?/) next;
+  ## if (name ~ /^\.\.?/) next; ## would prevent dot started files
   printf "%s%s%s\n", attr, dir, name
 }' 
 }

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Feb 15, 2010 at 17:20 UTC (comment 4.5)

--- iso9660.org 2010-02-05 02:38:37.000000000 +0100
+++ iso9660 2010-02-15 17:10:15.000000000 +0100
@@ -62,7 +62,7 @@

sub(" $", "", name)
## sub(";[0-9]+$", "", name) ## would break copyout
# skip . and ..

  • if (name ~ /^\.\.?/) next;

i think replacing it with this will be the right fix:

if (name ~ /^\.\.?$/) next;

@mc-butler
Copy link
Author

Changed by Unknown on Feb 15, 2010 at 22:23 UTC (comment 6)

IMHO skipping . and .. is already covered by the line: "/^d---------/ { next }", so this statement is not needed.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 5, 2011 at 6:24 UTC (comment 7)

  • Version changed from version not selected to master
  • Milestone changed from 4.7 to Future Releases
  • Branch state set to no branch
8000

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jun 26, 2013 at 14:09 UTC (comment 8)

  • Milestone changed from Future Releases to 4.8.9
  • Status changed from new to accepted
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jun 26, 2013 at 14:29 UTC (comment 9)

  • Keywords set to iso9660
  • Branch state changed from no branch to on review

Created branch 2006_more_info_about_iso,
initial [7b95b0a0ec87b79542b89ee3a388fb187dc8ba8c]

Please review.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 26, 2013 at 16:46 UTC (comment 10)

  • Votes set to andrew_b

Leading space should be stripped. :)

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 5, 2013 at 4:38 UTC (comment 11)

  • Branch state changed from on review to approved
  • Votes changed from andrew_b to andrew_b angel_il

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jul 5, 2013 at 12:25 UTC (comment 12)

  • Resolution set to fixed
  • Status changed from accepted to testing

Merged to master:

git log --pretty=oneline c6844e1 cb57614

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jul 5, 2013 at 12:29 UTC (comment 13)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 14, 2014 at 10:33 UTC (comment 14)

  • Branch state changed from approved to merged

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 10, 2014 at 12:53 UTC (comment 15)

  • Votes changed from andrew_b angel_il to committed-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaz slavaz

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.9
Development

No branches or pull requests
2 participants
@slavaz @mc-butler
0