Driver regression testing with roadtest

Posted Mar 19, 2022 13:42 UTC (Sat) by pabs (subscriber, #43278)
In reply to: Driver regression testing with roadtest by johill
Parent article: Driver regression testing with roadtest

BTW, are you aware of the patches that Debian applies to UML?

https://sources.debian.org/src/user-mode-linux/sid/debian...
https://tracker.debian.org/pkg/user-mode-linux

Driver regression testing with roadtest

Posted Mar 19, 2022 20:54 UTC (Sat) by johill (subscriber, #25196) [Link] (7 responses)

I wasn't (and we should probably discuss this on the uml list), but:

x-terminal-emulator - that's just changing a default, not sure it makes that much sense for non-debian, but the best would probably be to make a new Kconfig variable for it, defaulting to the current value xterm
/tmp/uml.ctl - similarly, and likely it should also be made runtime-configurable?
the strrchr fix is just outdated? the bug report for it is from 2008, the fix from 2009, and in 2011 the bug was fixed upstream in commit 2c51a4bc023
WRITE_ZEROES was submitted upstream

Driver regression testing with roadtest

Posted Mar 20, 2022 0:42 UTC (Sun) by pabs (subscriber, #43278) [Link] (6 responses)

Kconfig and runtime config values sound good to me. It seems that it wasn't noticed that strrchr fix was already applied because Debian's patch modifies KERNEL_DEFINES while the upstream change was to KBUILD_CFLAGS. I don't understand enough of the Linux build system to know why both exist and which one the strrchr fix should be in though.

Also, I see there is also a DocBook based linux(1) manual page and of course the Kconfig files duplicate the upstream ones:

https://sources.debian.org/src/user-mode-linux/5.16um1/li...
https://sources.debian.org/src/user-mode-linux/5.16um1/co...
https://sources.debian.org/src/user-mode-linux/5.16um1/co...

Driver regression testing with roadtest

Posted Mar 21, 2022 11:23 UTC (Mon) by johill (subscriber, #25196) [Link] (5 responses)

Do you want to propose a couple of patches then? :) Should be pretty simple, I'd think, but if not I guess I can also just write them quickly.

Driver regression testing with roadtest

Posted Mar 22, 2022 1:02 UTC (Tue) by pabs (subscriber, #43278) [Link] (4 responses)

Sorry, I'll have to leave that to you. My Linux kernel knowledge is minimal at this point and I'm not the UML maintainer in Debian, just a bystander that looked it at one point.

Driver regression testing with roadtest

Posted Mar 24, 2022 10:37 UTC (Thu) by riteshsarraf (subscriber, #11138) [Link] (2 responses)

Thank you for bringing this up. I will try to review the set of patches we're carrying in Debian, and what all can be pushed upstream.

Driver regression testing with roadtest

Posted Mar 24, 2022 10:51 UTC (Thu) by pabs (subscriber, #43278) [Link] (1 responses)

One other thing I was thinking; that Debian's src:user-mode-linux should be merged into src:linux (like the RT builds are) so it is always up to date with Debian's other Linux kernel packages.

https://kernel-team.pages.debian.net/kernel-handbook/

Driver regression testing with roadtest

Posted Mar 24, 2022 15:56 UTC (Thu) by riteshsarraf (subscriber, #11138) [Link]

Yes. That is something we've been targeting. Just that this hasn't had the urgency, given that in its current model, it works fine.

Driver regression testing with roadtest

Posted Mar 24, 2022 12:14 UTC (Thu) by johill (subscriber, #25196) [Link]

https://patchwork.ozlabs.org/project/linux-um/list/?serie...