Update UV reps #1411
Merged
Update UV reps #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying instructor-py with
|
| Latest commit: |
94bd701
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cab7a0d5.instructor-py.pages.dev |
| Branch Preview URL: | https://add-jsonref-supp.instructor-py.pages.dev |
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 94bd701 in 1 minute and 24 seconds
More details
- Looked at
118lines of code in2files - Skipped
0files when reviewing. - Skipped posting
16drafted comments based on config settings.
1. pyproject.toml:68
- Draft comment:
Added the jsonref dependency for google-genai. Ensure documentation explains its purpose. - Reason this comment was not posted:
Confidence changes required:80%<= threshold85%
None
2. pyproject.toml:1810
- Draft comment:
jsonref is added under the google-genai extra in requires-dist; verify consistency with similar extras. - Reason this comment was not posted:
Confidence changes required:60%<= threshold85%
None
3. uv.lock:135
- Draft comment:
Anthropic version update to 0.48.0; double-check for any breaking changes in its API. - Reason this comment was not posted:
Confidence changes required:80%<= threshold85%
None
4. uv.lock:141
- Draft comment:
Updated sdist URL, hash, and wheel for anthropic 0.48.0; ensure these details match the release info. - Reason this comment was not posted:
Confidence changes required:80%<= threshold85%
None
5. uv.lock:1648
- Draft comment:
Instructor package version bumped from 1.7.3 to 1.7.4; confirm that release notes and tests are updated. - Reason this comment was not posted:
Confidence changes required:70%<= threshold85%
None
6. uv.lock:1683
- Draft comment:
Added jsonref dependency under google-genai in uv.lock; check if similar addition is needed for all related extras consistently. - Reason this comment was not posted:
Confidence changes required:60%<= threshold85%
None
7. pyproject.toml:71
- Draft comment:
Added jsonref to the google-genai extra. Ensure that tests and documentation reflect this new dependency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
8. pyproject.toml:136
- Draft comment:
Verify that the trailing comma in the google-genai dependency list is acceptable in TOML—if not, remove it. - Reason this comment was not posted:
Confidence changes required:66%<= threshold85%
None
9. uv.lock:133
- Draft comment:
Bumped anthropic from 0.47.2 to 0.48.0. Confirm compatibility and corresponding test updates. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
10. uv.lock:1680
- Draft comment:
Added jsonref to the google-genai extra in the lock file. Ensure its version aligns with pyproject.toml. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
11. uv.lock:1751
- Draft comment:
jsonref is added again in a separate google-genai block. Confirm that this duplication is intentional and does not lead to version conflicts. - Reason this comment was not posted:
Confidence changes required:33%<= threshold85%
None
12. uv.lock:1802
- Draft comment:
Updated the anthropic requires-dist specifier to 0.48.0. Ensure downstream dependencies align with this bump. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
13. uv.lock:1816
- Draft comment:
Added jsonref with version constraints for the 'google-genai' extra in requires-dist. Confirm consistency across all extras. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
14. uv.lock:1838
- Draft comment:
Bumped anthropic in the requires-dev section to 0.48.0. Verify consistency with other dependency groups. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
15. uv.lock:1864
- Draft comment:
Updated the docs extra for google-genai to include jsonref. Ensure documentation and example usage reflect this change. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
16. uv.lock:1874
- Draft comment:
Bumped anthropic to 0.48.0 in the test-docs extra to match other updates. Confirm tests use the correct version. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%
None
Workflow ID: wflow_gWlgflk1asczmOjj
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
jsonreftogoogle-genaidependencies and updateanthropicversion inuv.lock.jsonref<2.0.0,>=1.1.0togoogle-genaiinpyproject.tomlanduv.lock.anthropicversion from0.47.2to0.48.0inuv.lock.instructorversion from1.7.3to1.7.4inuv.lock.This description was created by
for 94bd701. It will automatically update as commits are pushed.