feat: support snapped knobs #507
Open
+39
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericxgao
commented
May 6, 2025
| if (el.integral) { | ||
| float clamped_value = std::clamp(value, 0.f, 1.f); | ||
|
|
||
| unsigned v = (clamped_value >= 1.f) ? |
There was a problem hiding this comment.
I don't like this. But since knob positions span from 0-1 inclusive, the math required to get an index from the state is a little wonky - you can't do a naive round/floor operation because it will be missing states.
Ericxgao
commented
May 6, 2025
| @@ -184,6 +184,9 @@ private: | |||
| if (pot.display_mult > 1 && pot.display_mult != 100 && pot.display_base == 0 && pot.units == "") { | |||
| lv_arc_set_range(ui_ControlArc, 0, pot.display_mult); | |||
| hide_resolution_text(); | |||
| } else if (pot.integral) { | |||
| lv_arc_set_range(ui_ControlArc, pot.min_value, pot.max_value); | |||
There was a problem hiding this comment.
This worked like you said.
Ericxgao
commented
May 6, 2025
| @@ -100,6 +100,17 @@ static Knob create_base_knob(rack::app::Knob *widget) { | |||
| element.display_offset = pq->displayOffset; | |||
| element.integral = pq->snapEnabled; | |||
| element.display_precision = pq->displayPrecision; | |||
|
|
|||
| if (element.integral) { | |||
| auto switchPq = dynamic_cast<rack::engine::SwitchQuantity*>(pq); | |||
There was a problem hiding this comment.
Is this normal? I have to casxt the param quantity to a switchQuantity to properly get access to the labels array?
Ericxgao
commented
May 6, 2025
| element.pos_names[i] = pq->labels[i]; | ||
| // Check if pq is 86DB actually a SwitchQuantity with labels | ||
| auto switchPq = dynamic_cast<rack::engine::SwitchQuantity*>(pq); | ||
| if (switchPq) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danngreen
Updated with your suggestions, not sure why the old PR is gone.
Adding a few comments/questions below
Corresponding PR requests
4ms/metamodule-core-interface#2
4ms/metamodule-plugin-sdk#7