feat(web): replace NavBar with Header component and add blur effect (#945) #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/web/src/components/layout/header.tsx:16
- [nitpick] For consistency with the previous NavBar component, consider renaming 'isCurrentPath' to 'isActive'.
const isCurrentPath = (path: string) => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves renaming the
NavBarcomponent toHeaderand updating related references and configurations accordingly. The most important changes include modifying imports and component usage, updating configuration keys, and removing the oldNavBarcomponent.Changes to component imports and usage:
apps/web/src/app/layout.tsx: ReplacedNavBarwithHeaderin imports and component usage, and updated the configuration key fromnavItemstonavigationLinks. [1] [2] [3]Component addition and removal:
apps/web/src/components/layout/header.tsx: Added the newHeadercomponent with navigation links and path checking logic.apps/web/src/components/layout/nav-bar/index.tsx: Removed the oldNavBarcomponent.Configuration updates:
apps/web/src/config/index.ts: Updated the configuration key fromnavItemstonavigationLinks.apps/web/src/config/template.ts: Updated the configuration key fromnavItemstonavigationLinks.resolved: #945