refactoring: ♻️ Many things #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors dependency injection utilities and functions to introduce improved type annotations and updated naming conventions. Key changes include updating FastAPI dependency resolution, revising generic signatures for instance-getting functions, and renaming simple injectable classes to reflect their transient nature.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| injection/ext/fastapi.py | Refactored async dependency naming and assignment logic |
| injection/_core/scope.py | Added generic type annotations to get_scope |
| injection/_core/module.py | Updated generic signatures, refactored injectable type usage, and improved function signatures |
| injection/_core/injectables.py | Renamed SimpleInjectable to TransientInjectable |
| injection/_core/descriptors.py | Refactored lazy instance retrieval similar to FastAPIInject behavior |
Comments suppressed due to low confidence (1)
injection/ext/fastapi.py:21
- [nitpick] The variable name 'ainstance' may be ambiguous or mistaken; consider renaming it to 'lazy_instance' or another descriptive name for clarity.
ainstance = (module or mod()).aget_lazy_instance(cls, default)
Comment on lines
+600
to
601
| return AsyncInjectedFunction(metadata) # type: ignore[arg-type, return-value] | ||
|
|
There was a problem hiding this comment.
The use of a 'type: ignore' comment suggests a type mismatch; consider updating the type annotations for AsyncInjectedFunction to resolve this without suppressing errors.
Suggested change
| return AsyncInjectedFunction(metadata) # type: ignore[arg-type, return-value] | |
| assert isinstance(metadata, AsyncInjectMetadata), "metadata must be of type AsyncInjectMetadata" | |
| return AsyncInjectedFunction(metadata) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.