refactoring: ♻️ scope.py
#223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the scope management implementation in scope.py by replacing the previous _ScopeState class with a new ScopeState protocol and two concrete implementations for contextual and shared scopes. Key changes include updating import statements, redefining scope state classes with appropriate bindings, and modifying the get_scope and get_active_scopes functions to handle scope retrieval and binding more uniformly.
Comments suppressed due to low confidence (2)
injection/_core/scope.py:142
- Consider adding explicit type annotations for the parameters 'name' and 'default' in get_scope to align with the overloads and enhance type safety.
def get_scope(name, default=...): # type: ignore[no-untyped-def]
injection/_core/scope.py:126
- [nitpick] The variable name 'active_scopes' in get_active_scopes may cause confusion with the active_scopes property; consider renaming it (e.g., 'scopes_iter') for improved clarity.
active_scopes = (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.