8000 Run flake8 in warning only mode on Python 2 and 3 by cclauss · Pull Request #8 · 100/Solid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flake8 in warning only mode on Python 2 and 3 #8

Merged
merged 24 commits into from
Sep 1, 2017
Merged

Run flake8 in warning only mode on Python 2 and 3 #8

merged 24 commits into from
Sep 1, 2017

Conversation

cclauss
Copy link
Contributor
@cclauss cclauss commented Jun 28, 2017 •
edited
Loading

This will help us find and fix the Python 3 syntax errors (print_function, etc.) A step towards the resolution of #6

@cclauss
Copy link
Contributor Author
cclauss commented Jun 28, 2017

This is ready for review. I have used flake8 to clear the obvious Python3 incompatibilities so now py.tests run on Python 3. They fail and need to be fixed but that is beyond the scope of this PR.

@100
Copy link
Owner
100 commented Jun 28, 2017

Thank you, I'll look into fixing the test issues.

@emre-e emre-e mentioned this pull request Jul 6, 2017
Merged
@emre-e
Copy link
Contributor
emre-e commented Jul 6, 2017

Hi! I fixed the issues that causes the test to fails for python3 here. Could you please review? Here is my PR:
https://github.com/cclauss/Solid/pull/1/files

@cclauss
Copy link
Contributor Author
cclauss commented Jul 6, 2017

Awesome work @emre-e with the slick fixes.

@cclauss
Copy link
Contributor Author
cclauss commented Jul 6, 2017

Ready for review.

@100
Copy link
Owner
100 commented Jul 7, 2017

Thanks, I'll take a look in a few days and merge it in.

@100 100 merged commit f38ca49 into 100:master Sep 1, 2017
@cclauss cclauss deleted the patch-2 branch September 1, 2017 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @100 @emre-e
0