Add support for units and includeZero in Yaxis #187
Conversation
* Adds IncludeZero to support whether to always include zero or not. Default is to always include zero. * Adds IncludeUnits (units in Datadog json) to determine whether to show the unit label to the left of the yaxis or not.
|
Questions for other reviewers:
|
|
I came here to make a PR like this only to see that @nyanshak had already done it. I'm not involved in this project but would love to use this PR and am 👍 to the PR itself. :) |
|
LGTM. The failing tests look like failures for some Go versions due to golint. Probably worth checking if Travis CI needs some other args for those versions in another PR.
I think
The type is fine, IMO, unless consumers can get into an ugly state that's hard to debug (like the auto issue). I'd rather the UI behave poorly than have something downstream like Terraform breaks. Also, did you file a bug upstream about it? |
|
Consumers could get into a weird state if someone else were to edit this incorrectly in the json editor or the API. Unlike the other times we've seen similar problems (like "5" vs 5 in max/min), using string types here does not actually work in the UI. I just raised this through Datadog support, so... fingers crossed :) Thanks for reviewing, @yfronto |
|
Hey all! Anything I can to to help move this along? Thanks! |
Default is to always include zero.
the unit label to the left of the yaxis or not.