Return value of `enum` so it remains compatible with other enum extensions (e.g. stateful_enum) #52

kiyo-e · 2025-05-01T06:25:04Z

What does this PR do?

EnumHelp::I18n re-defines ActiveRecord::Base#enum but did not return the
value from super.
When another gem (notably stateful_enum) wraps enum and expects the
original Hash definition to be returned, the call chain receives nil (or a
Symbol) and crashes with:

NoMethodError: undefined method `map' for nil:NilClass
    .../stateful_enum/machine.rb:8:in `initialize'

This PR stores the result of super, executes EnumHelp’s I18n helpers, and
finally returns the original result object.
No other behaviour is changed.

Why is it needed?

Allows enum_help to coexist with popular gems that decorate enum
(stateful_enum etc.).
Removes the need for ad-hoc monkey-patches in downstream applications.

Implementation details

definitions = super           # call the next #enum implementation
…                         # existing i18n helper definitions
definitions                    # ← **return it**

No other lines were modified.

Backwards compatibility

The change only affects the return value; public APIs and generated I18n
helper methods are untouched.

Thank you for reviewing! Please let me know if further changes are required.

…stateful_enum)

Fix: return value of enum method to avoid breaking other gems (e.g., …

c0bd80f

…stateful_enum)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Return value of `enum` so it remains compatible with other enum extensions (e.g. stateful_enum) #52

Return value of `enum` so it remains compatible with other enum extensions (e.g. stateful_enum) #52

Uh oh!

Uh oh!

Uh oh!

Return value of enum so it remains compatible with other enum extensions (e.g. stateful_enum) #52

Are you sure you want to change the base?

Return value of enum so it remains compatible with other enum extensions (e.g. stateful_enum) #52

Uh oh!

Conversation

What does this PR do?

Why is it needed?

Implementation details

Backwards compatibility

Uh oh!

Uh oh!

Return value of `enum` so it remains compatible with other enum extensions (e.g. stateful_enum) #52

Return value of `enum` so it remains compatible with other enum extensions (e.g. stateful_enum) #52