Unbreak PF_RING #875
Merged
Unbreak PF_RING #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set zconf.data_link_size to unbreak the receive code and implement send_batch for PF_RING. While here, also fix compiler warnings in PF_RING code.
|
If this fixes it, I say let's merge it. I don't think there's an inherent reason to drop it, if it works! |
zakird
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set zconf.data_link_size to unbreak the receive code and implement send_batch for PF_RING to unbreak the send code. While here, also fix compiler warnings in PF_RING code.
Fixes #833. Fixes #694. Conflicts with #812. (Feel free to remove PF_RING instead of fixing it.)
Tested in a VM, and seems to work fine, results and hit rate look good. I don't have spare 10G hardware to install Linux on, so I cannot tell if ZMap with PF_RING is still able to send at 10G wire speed or not.