Optimize ZPipeline::mapEitherChunked
#9816
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
commented
Apr 22, 2025
| val builder: ChunkBuilder[Out] = ChunkBuilder.make[Out](chunk.size) | ||
| val iterator: Iterator[In] = chunk.iterator | ||
| val builder: ChunkBuilder[Out] = ChunkBuilder.make[Out](size) | ||
| val iterator = chunk.chunkIterator |
There was a problem hiding this comment.
TIL about ChunkIterator
1c4d37d to
22a99e2
Compare
guizmaii
commented
Apr 22, 2025
| @@ -1820,22 +1819,23 @@ object ZPipeline extends ZPipelinePlatformSpecificConstructors { | |||
| chunk => { | |||
| val size = chunk.size | |||
|
|
|||
| if (size == 0) reader | |||
There was a problem hiding this comment.
In another PR, we were talking about the fact that this Chunk can probably never be empty
22a99e2 to
45d3afa
Compare
kyri-petrou
reviewed
Apr 26, 2025
| while (iterator.hasNext && (error == null)) { | ||
| val a = iterator.next() | ||
| f(a) match { | ||
| while (iterator.hasNextAt(index) && (error == null)) { |
There was a problem hiding this comment.
I'm 99.99% sure that if you have size already stored locally you can simply iterate by checking index < size without having to call hasNextAt(index)
|
@guizmaii happy to merge it once you apply my recommendation above :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.