8000 sparse: add some prometheus metrics for sparse by sparknack · Pull Request #1202 · zilliztech/knowhere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sparse: add some prometheus metrics for sparse #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

sparse: add some prometheus metrics for sparse #1202

merged 1 commit into from
May 26, 2025

Conversation

sparknack
Copy link
Contributor

No description provided.

@mergify mergify bot added the dco-passed label May 22, 2025
@mergify Mergify
Copy link
mergify bot commented May 22, 2025

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@sparknack sparknack force-pushed the sparse-prometheus branch 2 times, most recently from 2166794 to fa96fab Compare May 22, 2025 02:36
@mergify mergify bot added the ci-passed label May 22, 2025
@alexanderguzhva
Copy link
Collaborator

/lgtm

@sparknack
Copy link
Contributor Author

/hold

@sparknack sparknack force-pushed the sparse-prometheus branch from fa96fab to c57eb5c Compare May 23, 2025 02:55
@sre-ci-robot sre-ci-robot removed the lgtm label May 23, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels May 23, 2025
@sparknack
Copy link
Contributor Author

issue: #1204

@sparknack
Copy link
Contributor Author

/kind improvement

@sparknack
Copy link
Contributor Author

/unhold

@sparknack sparknack force-pushed the sparse-prometheus branch from c57eb5c to 5e68233 Compare May 26, 2025 02:12
@mergify mergify bot removed the ci-passed label May 26, 2025
@sparknack sparknack force-pushed the sparse-prometheus branch 2 times, most recently from 880b273 to 07adbdd Compare May 26, 2025 02:28
@mergify mergify bot removed the needs-dco label May 26, 2025
@sparknack sparknack force-pushed the sparse-prometheus branch from 07adbdd to 9629516 Compare May 26, 2025 02:32
@sparknack
sparse: add some prometheus metrics for sparse inverted index
5a74827 
Add three prometheus metrics for sparse inverted index, including:

- sparse dataset nnz histgram
- sparse inverted index posting list length histgram
- sparse inverted index size

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
@sparknack sparknack force-pushed the sparse-prometheus branch from 9629516 to 5a74827 Compare May 26, 2025 06:33
@mergify mergify bot added the ci-passed label May 26, 2025
@foxspy
Copy link
Collaborator
foxspy commented May 26, 2025

/lgtm

foxspy
foxspy approved these changes May 26, 2025
View reviewed changes
Copy link
Collaborator
@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, sparknack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 33e13f3 into zilliztech:main May 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxspy foxspy foxspy approved these changes

@cqy123456 cqy123456 Awaiting requested review from cqy123456

@zhengbuqian zhengbuqian Awaiting requested review from zhengbuqian

Assignees

@alexanderguzhva alexanderguzhva

@foxspy foxspy

Labels
approved ci-passed dco-passed kind/improvement lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sparknack @alexanderguzhva @foxspy @sre-ci-robot
0