fix: avoid error caused by line_range type: null in discussion #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pxpeterxu |
line_range is complex. so AI often can't recognize API specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While testing the mr_discussions tool in MCP with Cursor, I encountered the following error for certain MRs:
Looking at the underlying API response, the issue was caused by a line_range block that did not include a type field. For example:
In this case, end.type was not just one of new/old/expandable but null.
Changes
Updated the zod schema for line_range to use the common LineRangeSchema, which already had
typeas nullableTesting
Confirmed that running the mr_discussions tool against the affected MR now works as expected using the following mcp.json configuration:
{ "mcpServers": { "GitLab": { "command": "npx", "args": ["-y", "github:wanderlog/gitlab-mcp"], "env": { "GITLAB_PERSONAL_ACCESS_TOKEN": "glpat-..." } } } }Full JSON of erroring response
{ "items": [ { "id": "49c2eb8b154f939a82c521f897234b2446bea3c1", "individual_note": false, "notes": [ { "id": 2568940190, "type": "DiffNote", "body": "Nit, since we're note passing in variant anymore, can you just pass in `defaultInputs` without destructuring it?", "author": { "username": "johndoe", "id": 21588835, "name": "John Doe", "avatar_url": "https://secure.gravatar.com/avatar/0cfdf18af5d52525ae4fd2f837780a997913a9d01dcfb5d363318ab24344185c?s=80&d=identicon", "web_url": "https://gitlab.com/johndoe" }, "created_at": "2025-06-17T19:57:10.740Z", "updated_at": "2025-06-17T19:57:10.740Z", "system": false, "noteable_id": 391825028, "noteable_type": "MergeRequest", "project_id": 9347980, "noteable_iid": 9156, "resolvable": true, "resolved": false, "resolved_by": null, "resolved_at": null, "position": { "base_sha": "e76bdae00d127d01909774f5739c02e9b8c4fdf4", "start_sha": "e76bdae00d127d01909774f5739c02e9b8c4fdf4", "head_sha": "1d91425520553846b1b779647dc5e1c3b466a03a", "old_path": "mobile/templates/GuidedNewTripPlanScreen/CreateTripOnboardingSurvey/makeCreateTripOnboardingSurveySlides.test.ts", "new_path": "mobile/templates/GuidedNewTripPlanScreen/CreateTripOnboardingSurvey/makeCreateTripOnboardingSurveySlides.test.ts", "position_type": "text", "new_line": null, "old_line": 69, "line_range": { "start": { "line_code": "709d83f82c721d666fe983bab82fafc2b75e79d6_67_65", "type": null, "old_line": 67, "new_line": 65 }, "end": { "line_code": "709d83f82c721d666fe983bab82fafc2b75e79d6_69_67", "type": "old", "old_line": 69, "new_line": null } } } } ] } ], "pagination": { "x_next_page": null, "x_page": 1, "x_per_page": 100, "x_prev_page": null, "x_total": 1, "x_total_pages": 1 } }