8000 FEAT: mr discussion with code diff by iwakitakuma33 · Pull Request #93 · zereight/gitlab-mcp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FEAT: mr discussion with code diff #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

FEAT: mr discussion with code diff #93

merged 1 commit into from
Jun 16, 2025

Conversation

iwakitakuma33
Copy link
Collaborator
@iwakitakuma33 iwakitakuma33 commented Jun 10, 2025

issue: #90

Made it possible to select multiple lines of diff when creating MR discussions.
The API is difficult to use, so there is a possibility that AI will not be able to create appropriate payloads.

API is complex.

#90 (comment)

index.ts Outdated
const hashedPath = crypto.createHash('sha1').update(path).digest('hex');
const _start = line_range?.start;
const start = {
line_code: `${hashedPath}_${_start.old_line || 'null'}_${_start.new_line || 'null'}`,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line_code

@zereight
Copy link
Owner
zereight commented Jun 10, 2025

The PR is Draft!

@iwakitakuma33
Copy link
Collaborator Author

@zereight

This pr does not meet the reporter requirements.

I just requested a check to a reporter.

issue: #90

Made it possible to select multiple lines of diff when creating MR discussions.
The API is difficult to use, so there is a possibility that AI will not be able to create appropriate payloads.
@iwakitakuma33
Copy link
Collaborator Author
iwakitakuma33 commented Jun 16, 2025

@zereight
I added line_range to create_mr_discussion.
But API is complex so sometimes AI Agent can't prepare a proper payload.

@iwakitakuma33 iwakitakuma33 requested a review from zereight June 16, 2025 03:55
@zereight zereight merged commit 672953f into main Jun 16, 2025
7 checks passed
@zereight
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0