Fix: Allow null for avatar_url in GitLab schemas #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a validation error in the
search_repositoriesMCP call whereitems.0.owner.avatar_urlwas expected to be a string but receivednullfrom the GitLab API.Closes #84
Problem Solved:
The GitLab API can return
nullfor a user'savatar_urlif they haven't set one. The existing schemas inschemas.tsdid not account for this, definingavatar_urlstrictly asz.string(), leading to validation errors [1].Changes Made:
The
avatar_urlfield has been made nullable in the relevant Zod schemas withinschemas.ts:GitLabOwnerSchema(around line 255):// Repository related schemas export const GitLabOwnerSchema = z.object({ username: z.string(), // Changed from login to match GitLab API id: z.number(), - avatar_url: z.string(), + avatar_url: z.string().nullable(), web_url: z.string(), // Changed from html_url to match GitLab API name: z.string(), // Added as GitLab includes full name state: z.string(), // Added as GitLab includes user state });[1]
Union type for user object (around line 214):
z.string(), z.object({ id: z.number(), username: z.string(), name: z.string(), - avatar_url: z.string(), + avatar_url: z.string().nullable(), web_url: z.string(), }).nullable() );[1]
GitLabForkParentSchemaowner object (around line 595):owner: z .object({ username: z.string(), // Changed from login to match GitLab API id: z.number(), - avatar_url: z.string(), + avatar_url: z.string().nullable(), }) .optional(), // Made optional to handle cases where GitLab API doesn't include it[1]
These changes ensure that the schema validation correctly handles
nullvalues foravatar_urlreturned by the GitLab API.Verification:
After applying these changes:
gitlab-mcpwas successfully completed.search_repositoriesMCP call was executed again.Invalid arguments: items.0.owner.avatar_url: Expected string, received nullerror, confirming the fix.