Fixed is_php_version #1646
Merged
Fixed is_php_version #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed RegExp for optimizer | Issue 1404
sergeyklay
commented
May 4, 2018
| * @param int|double|string $version - PHP version in any format: 7, 7.1, "7.1.1" | ||
| * @return boolean | ||
| */ | ||
| private function is_php_version($version) |
There was a problem hiding this comment.
Method name "
Issue1404Test::is_php_version" is not in camel caps format
sergeyklay
commented
May 4, 2018
kernels/ZendEngine2/main.h
Outdated
| @@ -550,7 +550,7 @@ int zephir_fetch_parameters(int num_args TSRMLS_DC, int required_args, int optio | |||
|
|
|||
| #define ZEPHIR_CHECK_POINTER(v) if (!v) fprintf(stderr, "%s:%d\n", __PRETTY_FUNCTION__, __LINE__); | |||
|
|
|||
| #define zephir_is_php_version(id) (PHP_VERSION_ID / 10 == id / 10 ? 1 : 0) | |||
| int zephir_is_php_version(id); | |||
There was a problem hiding this comment.
a parameter list without types is only allowed in a function definition
sergeyklay
commented
May 4, 2018
kernels/ZendEngine2/main.c
Outdated
| { | ||
| int php_major = PHP_VERSION_ID / 10000; | ||
| int php_minor = PHP_VERSION_ID / 100 - php_major * 100; | ||
| int php_release = PHP_VERSION_ID - (php_major * 10000 + php_minor * 100); |
There was a problem hiding this comment.
- int php_major = PHP_VERSION_ID / 10000;
+ int php_major = PHP_MAJOR_VERSION;
- int php_minor = PHP_VERSION_ID / 100 - php_major * 100;
+ int php_minor = PHP_MINOR_VERSION;
- int php_release = PHP_VERSION_ID - (php_major * 10000 + php_minor * 100);
+ int php_release = PHP_RELEASE_VERSION;Fix optimizer tests for CI
Fixed PSR2 for test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1404
/cc @Jurigag