8000 Improve `Attributes:classes()` and add tests by smnandre · Pull Request #3 · zenstruck/dom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Attributes:classes() and add tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Improve Attributes:classes() and add tests #3

merged 1 commit into from
May 21, 2025

Conversation

smnandre
Copy link
Contributor
  • Use preg_split for best performances
  • Type-hint return value as list
  • Add tests on this class (60 -> 96% lines cov)

Regarding array_filter and preg_split:

@smnandre
Improve Attributes:classes() and add tests
2131c49 
- Use preg_split for best performances
- Type-hint return value as list<string>
- Add tests on this class (60 -> 96% lines cov)

Regarding array_filter and preg_split:
- 30/50% improved perf
- https://3v4l.org/kA9P5
@kbond kbond merged commit 663c214 into zenstruck:1.x May 21, 2025
This was referenced May 21, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smnandre @kbond
0