This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Add verbose mode to Wiktionary #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version does cover every part of speech, definitions and examples provided by the API.
|
I think you can modify the code to make this patch as verbose mode of wiktionary. |
I wasn't aware that verbose mode exists. I will do this. |
|
BTW, could you add a screenshot on README? |
Sure 👍 |
Added screenshots of Wiktionary.
fkztw
pushed a commit
that referenced
this pull request
Oct 28, 2018
- [#274] Add verbose mode for wikitionary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previous version only showed the first definition provided by the API to the user.
This version does cover every part of speech , definitions and examples provided by the API ♻️.
I'm really sad it turned out to be O(n^3) but can't think of a better solution right now.
There is also some code repetition in query and show function. I'm not sure if this is a problem. I tried to follow instructions provided in the dictionaries/template.py and that's why it turned out to be repetitive.
Sometimes there are repetitions in the API that are parsed to the Record, for example for a word 'box'. It is a good idea to fix this issue in the future.