This repository was archived by the owner on Jul 10, 2023. It is now read-only.
[#148] Fix the bug when getting user home dir on Windows #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we use Appveyor to test if it works on Windows or we just bump version to 0.10.1 for this PR? |
|
Setting up Appveyor in the PR will be fine. |
|
Sure. It may take some time. |
|
take your time. |
|
Finally, we have Windows user :P |
|
I'm also curious about the printing colour escape sequence is legit in Win's terminal or not. |
|
Me, too. I don't think it will work. LOL |
Use `os.path.expanduser` instead of using `os.path.join` directly, since the formmer is better handled for Windows. ref: <https://docs.python.org/3/library/os.path.html#os.path.expanduser>
added 5 commits
February 24, 2018 20:34
+ Remove Python 2. + Added install part.
Install gnureadline for OSX with Python version <= 3.5. Install pyreadline for Windows.
No need to use patch for linux, darwin and windows because we will run test on all these platforms.
|
I gave up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
os.path.expanduserinstead of usingos.path.joindirectly,since the formmer is better handled for Windows.
https://docs.python.org/3/library/os.path.html#os.path.expanduser
ref: GitHub issue #148