8000 chore: use tsup insead of rollup by zce · Pull Request #320 · zce/velite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: use tsup insead of rollup #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 20, 2025
Merged

chore: use tsup insead of rollup #320

merged 10 commits into from
May 20, 2025

Conversation

zce
Copy link
Owner
@zce zce commented May 20, 2025

Summary by CodeRabbit

  • Chores
    • Switched the build system from Rollup to Tsup for improved bundling and type declaration generation.
    • Updated package configuration to support both CommonJS and ES module formats, with clearer export paths.
    • Removed Rollup-related dependencies and configuration files.
  • Refactor
    • Improved module loading in the Next.js example to use dynamic imports, optimizing runtime behavior.

Copy link
vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
velite-nextjs ❌ Failed (Inspect) May 20, 2025 3:20am

Copy link
coderabbitai bot commented May 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The updates transition the project's build system from Rollup to Tsup, reflected in both configuration and dependency changes. The package entry points and exports are restructured to support both CommonJS and ES module consumers. Additionally, a dynamic import is introduced in the Next.js example to defer loading a dependency until runtime.

Changes

File(s) Change Summary
package.json Replaced Rollup with Tsup as the build tool. Updated "main" to CommonJS, added "module" for ESM, expanded "exports" for dual module support, added Tsup configuration, changed build script, removed Rollup dependencies, and added Tsup dependency.
rollup.config.js Deleted the Rollup configuration file, removing all build and type declaration bundling logic previously used for the project.
examples/nextjs/next.config.ts Replaced static import of build from velite with a dynamic import, deferring module loading until runtime under specific conditions.

Sequence Diagram(s)

sequenceDiagram
    participant NextConfig as next.config.ts
    participant Velite as velite (dynamic import)
    Note over NextConfig: On startup, check (isDev || isBuild) and VELITE_STARTED
    alt Condition met
        NextConfig->>Velite: Dynamically import velite
        Velite-->>NextConfig: Provide build method
        NextConfig->>Velite: Call build()
    end
Loading

Poem

A bunny with code in its hat,
Swapped Rollup for Tsup—imagine that!
Now builds are swift, exports are neat,
Dynamic imports hop in with a beat.
With paws on the keys and a whisker twitch,
This project’s build is fast as a rabbit’s twitch!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 187864d and 7503ba0.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • examples/nextjs/next.config.ts (1 hunks)
  • package.json (2 hunks)
  • rollup.config.js (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zce zce merged commit 7835f41 into main May 20, 2025
2 of 4 checks passed
@zce zce deleted the tsup branch May 20, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0