8000 Use GC natively by denniswittich · Pull Request #301 · zauberzeug/rosys · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use GC natively #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use GC natively #301

wants to merge 1 commit into from

Conversation

denniswittich
Copy link
Contributor

Motivation

Rosys based systems lagged once every minute when the gc.collect() was called.

Implementation

Remove the mechanism that removd the native gc and instead collected once every minute.

Progress

  • Discuss if the manual collection should be optional
  • Remove unused code

@falkoschindler
Copy link
Contributor

@denniswittich Some quick thoughts:

  • Today we already merged PR Add a configuration for garbage_collection_mbyte_limit #300 allowing to configure the memory limit for garbage collection.
  • I'm not sure we can simply enable the automatic garbage collection. Our experiments (a few years ago) should significant interruptions with this default setting. But I guess we need to discuss our options in more detail.
  • Commenting out code in observe_memory_growth shouldn't make a difference as long as you don't call it in user code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniswittich @falkoschindler
0