-
Notifications
You must be signed in to change notification settings - Fork 3
Global code refactor #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…String field type
… of git repo by default and a .gitignore file.
…String field type
Majority of work here is realted to cleaning up the imports. I want the user to be able to intuitively search for classes to define using IDEs, so the imports have to have a good structure.
Added a new plugin to control the order of items in the navigation.
Added some index.md files, gor rid of excess files in the docs, controlling the order of elements via the awesome pages plugin. Improved some descriptions.
Changes will be described elswhere.
next step is to catch up with the docs and make sure other ways of loading the model still work.
In the next step I need to run tests and eliminate the remaining bugs
…ckage. The restructurization is to fight off the circular imports issue. There are still some remaining after this commit.
It will be the default fix and the aim for the next releases to move all type-checking imports into TYPE_CHECKING guard.
It's a bit of a dirty commit before the weekend and leaving for home. Changes will be elaborated on in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large refactoring of the code base has been completed. Many new features have been added and some have been improved. Enhancements, among others:
This PR implements all necessary features to run the models. More features will be added once the package gains traction and gets user feadback.