fix(cli): preven 8000 t .cmd on custom binaries #1038
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents .cmd from being added to anything like node, node.exe, or custom binaries.
|
@SamPoate thanks for the patch! From a quick look, it seems the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents .cmd from being added to anything like node, node.exe, or custom binaries.
// Copilots thoughts:
This pull request updates the
runCommandutility function to improve compatibility and security when executing commands on Windows systems.Compatibility improvements:
runCommandfunction inpackages/cli/src/utils/misc.jsto append.cmdonly for specific commands (npm,npx,yarn) by introducing a conditional check. This ensures better compatibility and avoids unnecessary modifications for other commands.