10000 Fix several issues assigned to me with one shot by tai271828 · Pull Request #33 · zztin/ctimer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix several issues assigned to me with one shot #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 9, 2020
Merged

Fix several issues assigned to me with one shot #33

merged 7 commits into from
Nov 9, 2020

Conversation

tai271828
Copy link
Collaborator

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • [ x Documentation Update
  • Other (please describe)

Description

Please refer to the commit messages which have been explicitly shown the issues I have worked on.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. ctimer --db ./data
  2. ctimer --db /tmp/ctimer_test_dir1
  3. ctimer --version

Expected behavior

Step 1 and 2 should launch ctimer smoothly with their on own database path. The step 3 should show the ctimer version.

Related Issue

Issue #25 #26 #32

zztin and others added 7 commits August 15, 2020 12:25
@zztin @tai271828
the window with mbox still doesn't come to front when there is a mbox.
5a5d777
@zztin @tai271828
During break the window is always on top of all screen. (It only work…
e9936e2 
…s like this now for the goal prompt to also show on top.)
@zztin @tai271828
flashing button need implementation
186747a
@tai271828
ci(dependency): introduce production requirements.txt
4c59a3e 
by installing expected packages via requirements.txt to make CI work

issue: zztin#25
@tai271828
feat(db): add an option to customize db path
2c2bdf4 
BREAKING CHANGE: issue: zztin#26
@tai271828
feat(version): show cli version
f4021bc 
this is the very basic and straitforward method to show the verison. It will be great once we complete the packaging and parse the package version directly like the "standard" method.

issue: zztin#32
@tai271828
style(template): update pull request template
bbeeacf 
The very first line without hightlihghting is ignored very often and user-unfriendly. Let's remove it.
zztin added a commit that referenced this pull request Nov 9, 2020
@zztin
merge PR #33
c30e7c0
@zztin zztin merged commit 59029ad into zztin:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tai271828 @zztin
0