8000 README: add link to Flutter pub by khoren93 · Pull Request #356 · zxing-cpp/zxing-cpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

README: add link to Flutter pub #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2022
Merged

README: add link to Flutter pub #356

merged 2 commits into from
Jul 8, 2022

Conversation

khoren93
Copy link
Contributor
@khoren93 khoren93 commented Jul 8, 2022

Hi there. Thanks for this awesome library!

This pull request adds a link to Flutter pub, which I hope someone finds useful. iOS and Android platforms are currently supported.
I'm open to suggestions for other features to be implemented.

Thanks a lot.

@axxel
Copy link
Collaborator
axxel commented Jul 8, 2022 8000

Interesting. I was not aware of this project. I had a glance at your github repository and noticed that you have a verbatim copy of the library sources inside your ios code. I was wondering whether #337 would change anything regarding this requirement of yours? If there is anything missing there, please let me know. Any other feedback also welcome as I'm not an iOS developer...

Regarding your readme update: what about adding some kind of hint to that link, making it clean that it is an external project?

@khoren93
Copy link
Contributor Author
khoren93 commented Jul 8, 2022

Thank you for the quick response.

I had to duplicate all the source code in the ios folder due to CocoaPods restrictions.
If anyone can help me get around this limitation, then i can add the pure Dart bindings to this repository without c++ files duplication, if you want)))

As for #337, unfortunately it won't help, because it adds support for native iOS, but my project uses dart FFI technology, which allows it to have one codebase for both iOS and Android.

I added a hint in the readme to make it clear that this is an external project.

@axxel
Copy link
Collaborator
axxel commented Jul 8, 2022

Thanks for the update. will merge.

About the inclusion of the sources: maybe a git submodule could be of help to remove this duplication inside your project? I'm not really familiar with them and don't know if you could include only parts of another repository. Or maybe simply a symlink?

@axxel axxel merged commit 8e0ca7c into zxing-cpp:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0