8000 add missing #include <cmath> for std::abs by th1722 · Pull Request #458 · zxing-cpp/zxing-cpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add missing #include <cmath> for std::abs #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

add missing #include <cmath> for std::abs #458

merged 1 commit into from
Dec 14, 2022

Conversation

th1722
Copy link
Contributor
@th1722 th1722 commented Dec 11, 2022 •
edited
Loading

This fixes and avoids "error: call to 'abs' is ambiguous".

@axxel
Copy link
Collaborator
axxel commented Dec 12, 2022

Thanks for the PR. Makes sens to me. But I have a question: where did you see this error message? (platform/compiler/version?)

@th1722
Copy link
Contributor Author
th1722 commented Dec 13, 2022

Thanks for the PR. Makes sens to me. But I have a question: where did you see this error message? (platform/compiler/version?)

platform: Ubuntu 22.10
compiler: Android SDK 33, Android NDK r19c(19.2.5345600) / r20c(20.1.5948944)
version: 1.4.0

I received that error message when I built LibreOffice with zxing-cpp.
However, that error occurred only in building PDFEncoder.cpp.

@axxel axxel merged commit 03b2bda into zxing-cpp:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th1722 @axxel
0