8000 Dont read from display frequency if it doesnt start with a number by Kuuuube · Pull Request #2054 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dont read from display frequency if it doesnt start with a number #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Dont read from display frequency if it doesnt start with a number #2054

merged 1 commit into from
Jun 18, 2025

Conversation

Kuuuube
Copy link
Member
@Kuuuube Kuuuube commented Jun 18, 2025

No description provided.

@Kuuuube Kuuuube requested a review from a team as a code owner June 18, 2025 01:58
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels Jun 18, 2025
@Kuuuube Kuuuube mentioned this pull request Jun 18, 2025
Closed
jamesmaa
jamesmaa approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator
@jamesmaa jamesmaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this account for frequency dicts that have strings like JLPT | {N5, N4... }?

@Kuuuube
Copy link
Member Author
Kuuuube commented Jun 18, 2025 •
edited
Loading

Yep, this change just requires that for numerical frequencies in the display frequency to be matched, they must be first. If there's anything before them that isn't a number it wont match the display frequency.

And if theres both no display frequency matched and the frequency value is negative (such as -1), the frequency for that dict will be ignored in the averaging logic.

@Kuuuube Kuuuube added this pull request to the merge queue Jun 18, 2025
Merged via the queue into yomidevs:master with commit 8799fc1 Jun 18, 2025
25 checks passed
@Kuuuube Kuuuube deleted the document-freq-exclude branch June 18, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuuuube @jamesmaa
0