8000 Add `{glossary-plain}` and `{glossary-plain-no-dictionary}` handlebars by Kuuuube · Pull Request #2047 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add {glossary-plain} and {glossary-plain-no-dictionary} handlebars #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2025

Conversation

Kuuuube
Copy link
Member
@Kuuuube Kuuuube commented Jun 13, 2025

People keep asking for this for some reason.

Examples (読む):

{glossary-plain} {glossary-plain-no-dictionary}
image image

No {glossary-plain-brief} since this is already about as brief as it gets.

Will conflict with #2045.

@Kuuuube Kuuuube requested a review from a team as a code owner June 13, 2025 20:55
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels Jun 13, 2025
@jamesmaa
Copy link
Collaborator

Naming: maybe glossary-raw? "Plain" feels a bit vague and we also have "brief". Just starting a discussion

@Kuuuube
Copy link
Member Author
Kuuuube commented Jun 16, 2025

Only reason for using "plain" is because we already have the furigana handlebars that use that to differentiate they arent html.

@Kuuuube Kuuuube added this pull request to the merge queue Jun 18, 2025
Merged via the queue into yomidevs:master with commit 690d400 Jun 18, 2025
25 of 26 checks passed
@Kuuuube Kuuuube deleted the add-plain-glossary branch June 18, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0