10000 Add option to reset settings of individual profiles by Kuuuube · Pull Request #1981 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add option to reset settings of individual profiles #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By cli 8000 cking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

Kuuuube
Copy link
Member
@Kuuuube Kuuuube commented May 3, 2025

Since adding profiles clones the settings of an existing profile, there's no reasonable way for a user to create a default profile or get one back to default without resetting all of their settings.

@Kuuuube Kuuuube requested a review from a team as a code owner May 3, 2025 17:22
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design area/settings This issue or PR is related to settings. labels May 3, 2025
Copy link
Collaborator
@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested this and gave it a quick lookover. LGTM

@Kuuuube Kuuuube added this pull request to the merge queue May 5, 2025
Merged via the queue into yomidevs:master with commit 7c5bd9d May 5, 2025
25 of 26 checks passed
@Kuuuube Kuuuube deleted the allow-resetting-profiles branch May 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/settings This issue or PR is related to settings. area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0