8000 Check for wanakanaEnabled on search page before applying kana conversion by Kuuuube · Pull Request #1966 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Check for wanakanaEnabled on search page before applying kana conversion #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Check for wanakanaEnabled on search page before applying kana conversion #1966

merged 1 commit into from
Apr 22, 2025

Conversation

Kuuuube
Copy link
Member
@Kuuuube Kuuuube commented Apr 22, 2025 •
edited
Loading

Fixes all languages getting Japanese IME text substitutions instead of just Japanese on search page.

Regression introduced in #1875

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design priority/high High priority issue/PR regression This issue or PR is related to a regression labels Apr 22, 2025
@Kuuuube Kuuuube requested a review from a team as a code owner April 22, 2025 23:35
@github-actions GitHub Actions
Copy link

⚠️ Visual changes detected by playwright; please check the report to verify if they are desirable.

@Kuuuube Kuuuube added this pull request to the merge queue Apr 22, 2025
Merged via the queue into yomidevs:master with commit a018e13 Apr 22, 2025
25 checks passed
@Kuuuube Kuuuube deleted the fix-wanakana-enabled-wrong branch April 22, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug priority/high High priority issue/PR regression This issue or PR is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuuuube @jamesmaa
0