Update search query text when searching and set cursor to end of line #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casheeew
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit strange to type something ending in
んwith a singlenon the end and then see the search happen butndoesn't becomeん. This doesn't matter for strictly usability (Yomitan searches theんanyways) but it feels weird. The user searching can be taken similarly to the user acknowledging that composing is finished and converting everything should be fine.With this change for example typing
どnand searching will make it automatically becomeどんin the search bar.Clicking in the middle of the search text, searching, then hitting backspace or typing and having the text cursor end up back where you clicked before your searched is also weird. And especially annoying when trying to quickly wipe the search box (ctrl + shift + backspace).