-
Notifications
You must be signed in to change notification settings - Fork 151
allow multiple anki note loadouts #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow multiple anki note loadouts #1930
Conversation
289b6f5
to
80d2f53
Compare
80d2f53
to
79cda1d
Compare
I added a basic check for this now.
I've now set it to create kanji the kanji card format only for
I would keep the first icon group horizontal, because I think lots of people will complain if their view note button gets moved, and if someone has the icons for flags and tags enabled, the flags and tags are probably on the first/main card format and the UI is better when these are shown horizontally. The line should help with any possible confusion at first. |
applied that css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poked around a bit on desktop and couldn't find anything broken. Maybe @Kuuuube can poke around as well and give a review?
@jamesmaa do you have any takes about the naming here? Also, maybe we should rename the card templates setting to "anki field templates" or something to make it more different from however we end up naming this option: |
If we're trying to avoid the Card vs Note anki terminology, maybe we can write "Configure Anki flashcard fields" and "Configure Anki flashcard handlebar templates"? For non-anki users, "flashcard" is easy to understand what's going on. For power anki users who already know "card" and "note", "flashcard" would be new nomenclature that shouldn't overload any existing terms |
Honestly "Anki card templates" would be a better name for "Anki card format" but we're already using that |
The functionality all looks good for merging this from my testing. Code looks fine. I'm still not loving calling the card templates (or whatever we should call them) "notes". Also I think the delete button should say more than just "Delete". Maybe "Delete Card Template" (and the confirm dialog should match). Also though I wouldn't consider it a requirement for this pr, I'm 100% sure someone is going to ask for:
As for the "formats" "templates" problem, I think we should just rename the current "templates" option. They can just be named "Anki Handlebars" and they're already called that by many people. |
Hopefully everything is renamed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
closes #893