8000 allow multiple anki note loadouts by StefanVukovic99 · Pull Request #1930 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

allow multiple anki note loadouts #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StefanVukovic99
Copy link
Collaborator
@StefanVukovic99 StefanVukovic99 commented Apr 2, 2025

closes #893

8000
Copy link
github-actions bot commented Apr 2, 2025

@StefanVukovic99 StefanVukovic99 force-pushed the 893-multiple-anki-notes branch from 289b6f5 to 80d2f53 Compare April 3, 2025 14:37
@StefanVukovic99 StefanVukovic99 force-pushed the 893-multiple-anki-notes branch from 80d2f53 to 79cda1d Compare April 3, 2025 18:11
@StefanVukovic99
Copy link
Collaborator Author

Can we add a hardcoded limit for how many new note types we can add? Something reasonable like 5

I added a basic check for this now.

Is it possible to remove this in non-ja languages and default to one note type?

I've now set it to create kanji the kanji card format only for ['ja', 'zh', 'yue']. I don't think anyone's been using kanji dictionaries for korean or viet so that should be fine?

can we have all the icons line downwards for consistency?

I would keep the first icon group horizontal, because I think lots of people will complain if their view note button gets moved, and if someone has the icons for flags and tags enabled, the flags and tags are probably on the first/main card format and the UI is better when these are shown horizontally. The line should help with any possible confusion at first.

@StefanVukovic99
Copy link
Collaborator Author

connection line is off center

applied that css

Copy link
Collaborator
@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked around a bit on desktop and couldn't find anything broken. Maybe @Kuuuube can poke around as well and give a review?

@StefanVukovic99
Copy link
Collaborator Author

@jamesmaa do you have any takes about the naming here? Notes, Card formats, Note presets ... ?

Also, maybe we should rename the card templates setting to "anki field templates" or something to make it more different from however we end up naming this option:
image

@jamesmaa
Copy link
Collaborator

@jamesmaa do you have any takes about the naming here? Notes, Card formats, Note presets ... ?

Also, maybe we should rename the card templates setting to "anki field templates" or something to make it more different from however we end up naming this option: image

If we're trying to avoid the Card vs Note anki terminology, maybe we can write "Configure Anki flashcard fields" and "Configure Anki flashcard handlebar templates"? For non-anki users, "flashcard" is easy to understand what's going on. For power anki users who already know "card" and "note", "flashcard" would be new nomenclature that shouldn't overload any existing terms

@jamesmaa
Copy link
Collaborator

Honestly "Anki card templates" would be a better name for "Anki card format" but we're already using that

@Kuuuube
Copy link
Member
Kuuuube commented Apr 21, 2025

The functionality all looks good for merging this from my testing. Code looks fine.

I'm still not loving calling the card templates (or whatever we should call them) "notes". Also I think the delete button should say more than just "Delete". Maybe "Delete Card Template" (and the confirm dialog should match).

Also though I wouldn't consider it a requirement for this pr, I'm 100% sure someone is going to ask for:

  1. An option to make the book button view all card templates at once
  2. A way to re-arrange the card formats

As for the "formats" "templates" problem, I think we should just rename the current "templates" option. They can just be named "Anki Handlebars" and they're already called that by many people.

@StefanVukovic99
Copy link
Collaborator Author

Hopefully everything is renamed now

Copy link
Member
@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Apr 24, 2025
Merged via the queue into yomidevs:master with commit 70bead0 Apr 24, 2025
26 checks passed
@StefanVukovic99 StefanVukovic99 deleted the 893-multiple-anki-notes branch April 24, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to 6F0C comment
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dynamically adding different anki card types in the popup
4 participants
0