8000 Add 'language' parameter to audio API call by tiberiuiurco · Pull Request #1893 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add 'language' parameter to audio API call #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

tiberiuiurco
Copy link

For improving the audio server API, adding a 'language' parameter to the API call would make things more organized for working with multiple languages.
I added that parameter.

@tiberiuiurco tiberiuiurco requested a review from a team as a code owner March 19, 2025 08:39
Copy link
Member
@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just some styling suggestions.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/audio The issue or PR is related to audio labels Mar 19, 2025
@tiberiuiurco tiberiuiurco requested a review from Kuuuube March 20, 2025 05:36
@Kuuuube Kuuuube dismissed their stale review March 21, 2025 18:36

resolved

@Kuuuube Kuuuube added this pull request to the merge queue Mar 21, 2025
Merged via the queue into yomidevs:master with commit 63bf9e6 Mar 21, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/audio The issue or PR is related to audio kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0