Detect missing entries when dicts fail to import with Check Integrity button
#1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all for putting this into advance settings |
Done |
jamesmaa
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1582. Tested on Firefox and Chromium.
Checking integrity is kindof pointless if it can't even check if your dicts have the expected amount of entries.
Ideally this would be automatic but unfortunately it isn't reasonable to automatically show this when a user enters the settings page due to how long it takes to run over the entire database for the integrity check.
Also makes Unassociated Data and other check integrity data displays not a json string dump.
It may be worth pulling the
Check Integritybutton back into advanced settings instead of debug settings since especially on mobile, users often have issues with their dicts partially importing due to their device turning off or the browser hanging from battery saving. Though, this is "debugging" still.Dict counts before integrity check (same as before this PR):
Dict counts after integrity check:
Unassociated Data:
