8000 IOS-11839 numberOfSmallCells이 0이하가 되는 케이스에서 guard문 처리 by ParkHayoung · Pull Request #1 · yogiyo/XLPagerTabStrip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

IOS-11839 numberOfSmallCells이 0이하가 되는 케이스에서 guard문 처리 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2024
< 8000 div class="sticky-content">
Merged

IOS-11839 numberOfSmallCells이 0이하가 되는 케이스에서 guard문 처리 #1

merged 1 commit into from
Jun 27, 2024

Conversation

ParkHayoung
Copy link 
let newSuggestedStretchedCellWidth = (collectionViewAvailiableWidth - totalWidthOfLargeCells - cellSpacingTotal) / CGFloat(numberOfSmallCells)
  • 연산자 numberOfSmallCells 값이 0 이하가 되면서 발생한다고 추정.
  • guard문 추가하여 0이하가 된 경우 suggestedStretchedCellWidth 을 return 하도록 처리

@ParkHayoung ParkHayoung requested review from a team, beomcheol, hyunjeongkim and junsuk-bang and removed request for a team June 25, 2024 06:47
@ParkHayoung ParkHayoung merged commit 4a53389 into spm Jun 27, 2024
1 check passed
@ParkHayoung ParkHayoung deleted the feature/IOS-11839-fix-stretched-cell-widths-calculation branch June 27, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janghunlee janghunlee janghunlee approved these changes

@gwhwang gwhwang gwhwang approved these changes

@hyunjeongkim hyunjeongkim hyunjeongkim approved these changes

@beomcheol beomcheol Awaiting requested review from beomcheol beomcheol was automatically assigned from yogiyo/ios-developer

@junsuk-bang junsuk-bang Awaiting requested review from junsuk-bang junsuk-bang was automatically assigned from yogiyo/ios-developer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ParkHayoung @janghunlee @gwhwang @hyunjeongkim
0