forked from facebook/hhvm
-
Notifications
You must be signed in to change notification settings - Fork 0
Tags: yns88/hhvm
Tags
Modify serverBigCode to parse all tokens before the target token Summary: Previously we only extract all identifier tokens before the target as our context. However, this is no longer used in production for ranked autocomplete, and we need to extract all tokens including syntactic tokens and punctuations. In this diff, we use the `tast` for identifying the target tokens (member access, local var), and use the full fidelity syntax tree to extract the context tokens. Reviewed By: skim9 Differential Revision: D21617954 fbshipit-source-id: 1dafec236ee7827f77e9c86cc64000cbf9b2c2ba
Fix a crash with freed LdapResults Summary: An LdapResultEntry keeps a reference to its LdapResult so that the LdapResult can't be destroyed while the LdapResultEntry is alive. But ldap_free_result can still free its owned data, and invalidate LdapResultEntry::data. Make sure the LdapResult is valid before using the LdapResultEntry. Reviewed By: oulgen Differential Revision: D21625435 fbshipit-source-id: 038e45f7332abbb10390b6121d73569b46696a37
Eliminate live relocation Summary: When the EvalPerfRelocate is set, then after that many requests, we'll relocate functions in the TC. I suppose the benefit of doing this relocation is that we can test that we perform this "live relocation" correctly and invalidate all translation metadata that goes stale when we do so, but since we don't actually use this mode in production, it's not useful to maintain it... markw65 notes that relocation may have been useful for ARM since indirect jumps are quite expensive there, but now that we smash all the jumps in optimized translations in JIT deserialize mode, that benefit is also greatly reduced. Delete this option, the reloc debug map file, and the live relocation logic. Reviewed By: markw65 Differential Revision: D21610436 fbshipit-source-id: ffb60afff9ba2d936ff482d7541aef440efd51e3
Eliminate live relocation Summary: When the EvalPerfRelocate is set, then after that many requests, we'll relocate functions in the TC. I suppose the benefit of doing this relocation is that we can test that we perform this "live relocation" correctly and invalidate all translation metadata that goes stale when we do so, but since we don't actually use this mode in production, it's not useful to maintain it... markw65 notes that relocation may have been useful for ARM since indirect jumps are quite expensive there, but now that we smash all the jumps in optimized translations in JIT deserialize mode, that benefit is also greatly reduced. Delete this option, the reloc debug map file, and the live relocation logic. Reviewed By: markw65 Differential Revision: D21610436 fbshipit-source-id: ffb60afff9ba2d936ff482d7541aef440efd51e3
Add a Watchman sockname setting Summary: I originally added it as a server arg, but decided to move it to server local config instead. This way: * it's not exposed as a server/client argument to the end users * it works with both hh_server and hh_client without having to thread it through Reviewed By: ljw1004 Differential Revision: D21588419 fbshipit-source-id: ca0b78d5fecaea05abe418e1a7c39c555adcefba
Fixes to remove the check of demangling and increased buffer size for… … names Summary: This diff increases the size of buffer for reading mangled names and removes a demangling check which is no longer needed. Reviewed By: ottoni, marksantaniello Differential Revision: D21574700 fbshipit-source-id: bc0f36816bd3623d82037476124a8eb54b2ac85c
Make hh_server aware of .hackpartial files Summary: Adds "hackpartial" to several filter lists that are used by the client and server to collect files. I found these by searching for the `hck` string. Reviewed By: DavidSnider Differential Revision: D21541924 fbshipit-source-id: a75a68abd460817404eabdc4706f477e02d9c89d
compiler id: do not skip revisions with no files in root dir Reviewed By: markw65 Differential Revision: D21528525 fbshipit-source-id: efdf23b499722b9405d3c6bfe1a888ce43bfe2fc
PreviousNext