8000 Return unobserve functions from observe and observeDeep methods by giraugh · Pull Request #668 · yjs/yjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Return unobserve functions from observe and observeDeep methods #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return unobserve functions from observe and observeDeep methods #668

wants to merge 1 commit into from

Conversation

giraugh
Copy link
@giraugh giraugh commented Oct 17, 2024 •
edited
Loading

Closes #327

Went looking for this feature and spotted the issue so thought I'd try my hand at the simple change. Happy to make further changes or add/update tests if desired 👍

Thanks for all your work on y.js :)

@giraugh giraugh changed the title Return unobserve functions from observe and observeDeep methods (Fix #327) Return unobserve functions from observe and observeDeep methods Oct 17, 2024
@dmonad
Copy link
Member
dmonad commented Oct 19, 2024

Thanks for the PR!
I'm not sure if I like the approach. I'd prefer observe(f) to return f. I added a comment in #327.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return an unobserve function from observe and observeDeep
2 participants
@giraugh @dmonad
0