8000 Add delimiter override option for CSVs by evenreven · Pull Request #865 · yippee-fun/phlex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add delimiter override option for CSVs #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from evenreven:main
Feb 18, 2025
Merged

Conversation

evenreven
Copy link
Contributor

If you want to render values separated with, say, semicolon, this patch lets you do this:

users = User.all

UserExport.new(users, delimiter: ";").call

Since the vast majority will use commas, I've set comma as the default keyword argument, so this will still work:

users = User.all

UserExport.new(users).call

Also added a quickdraw test.

Hope this looks okay! This is my first PR here, so if I'm missing any coding standard, let me know. :)

@joeldrapper joeldrapper merged commit 3a74386 into yippee-fun:main Feb 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0